When returning an error, use "return" instead of "?"

Instead of

    Err(...)?;

which is correct but not idiomatic, write this:

    return Err(...);

This was found by clippy lintt try_err:
https://rust-lang.github.io/rust-clippy/master/index.html#try_err

Sponsored-by: author

2 files changed, 4 insertions, 4 deletions

diff --git a/sq/src/commands/net.rs b/sq/src/commands/net.rs
index 322ff8a0..899c65fd 100644
--- a/sq/src/commands/net.rs
+++ b/sq/src/commands/net.rs
@@ -91,9 +91,9 @@ pub fn dispatch_keyserver(config: Config, m: &clap::ArgMatches) -> Result<()> {
                 serialize_keyring(&mut output, &certs,
                                   m.is_present("binary"))?;
             } else {
-                Err(anyhow::anyhow!(
+                return Err(anyhow::anyhow!(
                     "Query must be a fingerprint, a keyid, \
-                     or an email address: {:?}", query))?;
+                     or an email address: {:?}", query));
             }
         },
         ("send",  Some(m)) => {
diff --git a/sq/src/sq.rs b/sq/src/sq.rs
index fb6567f5..1c692ec0 100644
--- a/sq/src/sq.rs
+++ b/sq/src/sq.rs
@@ -137,8 +137,8 @@ fn load_keys<'a, I>(files: I) -> openpgp::Result<Vec<Cert>>
         let cert = Cert::from_file(f)
             .context(format!("Failed to load key from file {:?}", f))?;
         if ! cert.is_tsk() {
-            Err(anyhow::anyhow!(
-                "Cert in file {:?} does not contain secret keys", f))?;
+            return Err(anyhow::anyhow!(
+                "Cert in file {:?} does not contain secret keys", f));
         }
         certs.push(cert);
     }