diff options
author | Justus Winter <justus@sequoia-pgp.org> | 2020-10-20 12:40:56 +0200 |
---|---|---|
committer | Justus Winter <justus@sequoia-pgp.org> | 2020-10-20 16:09:58 +0200 |
commit | de3922605692cee3edb274aa70acd4d1c61589dd (patch) | |
tree | 98198b2c1656c093e3475dd388ece8a70c1ca300 /openpgp | |
parent | f3461ce5b2161bb74c3b1b69d13f4f8a3bd7792e (diff) |
openpgp: Return the reader in PacketParserEOF.
Diffstat (limited to 'openpgp')
-rw-r--r-- | openpgp/src/parse.rs | 39 | ||||
-rw-r--r-- | openpgp/src/parse/packet_parser_builder.rs | 4 |
2 files changed, 29 insertions, 14 deletions
diff --git a/openpgp/src/parse.rs b/openpgp/src/parse.rs index d5cad160..5225d50f 100644 --- a/openpgp/src/parse.rs +++ b/openpgp/src/parse.rs @@ -3327,26 +3327,37 @@ enum ParserResult<'a> { /// # Ok(()) } /// ``` #[derive(Debug)] -pub struct PacketParserEOF { +pub struct PacketParserEOF<'a> { state: PacketParserState, - + reader: Box<dyn BufferedReader<Cookie> + 'a>, last_path: Vec<usize>, } -impl PacketParserEOF { +impl<'a> PacketParserEOF<'a> { /// Copies the important information in `pp` into a new /// `PacketParserEOF` instance. - fn new(mut state: PacketParserState) -> Self { + fn new(mut state: PacketParserState, + reader: Box<dyn BufferedReader<Cookie> + 'a>) + -> Self { state.message_validator.finish(); state.keyring_validator.finish(); state.cert_validator.finish(); PacketParserEOF { - state: state, + state, + reader, last_path: vec![], } } + /// Creates a placeholder instance for PacketParserResult::take. + fn empty() -> Self { + Self::new( + PacketParserState::new(Default::default()), + buffered_reader::Memory::with_cookie(b"", Default::default()) + .as_boxed()) + } + /// Returns whether the stream is an OpenPGP Message. /// /// A [`Message`] has a very specific structure. Returns `true` @@ -3554,6 +3565,11 @@ impl PacketParserEOF { Some(self.last_path.len() as isize - 1) } } + + /// Returns the exhausted reader. + pub fn into_reader(self) -> Box<dyn BufferedReader<Cookie> + 'a> { + self.reader + } } /// The result of parsing a packet. @@ -3575,7 +3591,7 @@ pub enum PacketParserResult<'a> { /// A `PacketParser` for the next packet. Some(PacketParser<'a>), /// Information about a fully parsed packet sequence. - EOF(PacketParserEOF), + EOF(PacketParserEOF<'a>), } impl<'a> PacketParserResult<'a> { @@ -3642,7 +3658,8 @@ impl<'a> PacketParserResult<'a> { /// Produces a new `Result`, containing mutable references into the /// original `PacketParserResult`, leaving the original in place. pub fn as_mut(&mut self) - -> StdResult<&mut PacketParser<'a>, &mut PacketParserEOF> { + -> StdResult<&mut PacketParser<'a>, &mut PacketParserEOF<'a>> + { match self { PacketParserResult::Some(pp) => Ok(pp), PacketParserResult::EOF(eof) => Err(eof), @@ -3659,15 +3676,13 @@ impl<'a> PacketParserResult<'a> { pub fn take(&mut self) -> Self { mem::replace( self, - PacketParserResult::EOF( - PacketParserEOF::new( - PacketParserState::new(Default::default())))) + PacketParserResult::EOF(PacketParserEOF::empty())) } /// Maps a `PacketParserResult` to `Result<PacketParser, /// PacketParserEOF>` by applying a function to a contained `Some` /// value, leaving an `EOF` value untouched. - pub fn map<U, F>(self, f: F) -> StdResult<U, PacketParserEOF> + pub fn map<U, F>(self, f: F) -> StdResult<U, PacketParserEOF<'a>> where F: FnOnce(PacketParser<'a>) -> U { match self { @@ -4448,7 +4463,7 @@ impl <'a> PacketParser<'a> { if ! fake_eof && recursion_depth == 0 { t!("Popped top-level container, done reading message."); - let mut eof = PacketParserEOF::new(state_); + let mut eof = PacketParserEOF::new(state_, reader_); eof.last_path = self.last_path; return Ok((self.packet, PacketParserResult::EOF(eof))); diff --git a/openpgp/src/parse/packet_parser_builder.rs b/openpgp/src/parse/packet_parser_builder.rs index 3e3d5a2e..736ed4d1 100644 --- a/openpgp/src/parse/packet_parser_builder.rs +++ b/openpgp/src/parse/packet_parser_builder.rs @@ -432,9 +432,9 @@ impl<'a> PacketParserBuilder<'a> { pp.state.cert_validator.push(pp.packet.tag()); Ok(PacketParserResult::Some(pp)) }, - ParserResult::EOF((_reader, state, _path)) => { + ParserResult::EOF((reader, state, _path)) => { // `bio` is empty. We're done. - Ok(PacketParserResult::EOF(PacketParserEOF::new(state))) + Ok(PacketParserResult::EOF(PacketParserEOF::new(state, reader))) } } } |