diff options
| author | Justus Winter <justus@sequoia-pgp.org> | 2020-04-20 11:58:04 +0200 |
|---|---|---|
| committer | Justus Winter <justus@sequoia-pgp.org> | 2020-04-20 18:43:42 +0200 |
| commit | d37518937219aa803c9856a1792c1fc518c66793 (patch) | |
| tree | c6bc9fbea91c0f87dfdacb70709973c53d8df42a /openpgp/src/serialize/stream.rs | |
| parent | 869258d34ffb83ef8790d94a6325ffef8037f419 (diff) | |
openpgp: Don't finalize the Signer in Drop.
- Previously, Signer::drop made an effort to finalize the filter.
This, however, is only a best-effort mechanism: It cannot report
errors.
- Because of this, we now believe that it actually exacerbates the
problem of downstream users not finalizing the filter: It will
work most of the time, but sometimes fail.
Diffstat (limited to 'openpgp/src/serialize/stream.rs')
| -rw-r--r-- | openpgp/src/serialize/stream.rs | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/openpgp/src/serialize/stream.rs b/openpgp/src/serialize/stream.rs index a913684a..5ebb7b37 100644 --- a/openpgp/src/serialize/stream.rs +++ b/openpgp/src/serialize/stream.rs @@ -900,12 +900,6 @@ impl<'a> Signer<'a> { } } -impl<'a> Drop for Signer<'a> { - fn drop(&mut self) { - let _ = self.emit_signatures(); - } -} - impl<'a> fmt::Debug for Signer<'a> { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { f.debug_struct("Signer") |