diff options
author | Neal H. Walfield <neal@pep.foundation> | 2020-06-29 16:56:55 +0200 |
---|---|---|
committer | Neal H. Walfield <neal@pep.foundation> | 2020-06-29 18:28:05 +0200 |
commit | 92c5a1612995201afbcd1b9b5b6d749cf1b2d6a7 (patch) | |
tree | 2d54c8654d014bc40e1b3a1c9a1d73d501739435 /openpgp/src/policy.rs | |
parent | cd01d146546afb04fcbe493a2fa5d81077d646f4 (diff) |
openpgp: Don't unnecessarily set signature subpackets.
- When using the `SignatureBuilder`, the signature creation time and
issuer subpackets will be correctly set by default.
- Don't do it explicitly.
Diffstat (limited to 'openpgp/src/policy.rs')
-rw-r--r-- | openpgp/src/policy.rs | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/openpgp/src/policy.rs b/openpgp/src/policy.rs index a4635201..1cdb39ac 100644 --- a/openpgp/src/policy.rs +++ b/openpgp/src/policy.rs @@ -1511,8 +1511,6 @@ mod test { = Key4::generate_rsa(4096)?.into(); let binding = signature::SignatureBuilder::new(SignatureType::SubkeyBinding) .set_key_flags(&KeyFlags::default().set_transport_encryption(true))? - .set_issuer_fingerprint(cert.fingerprint())? - .set_issuer(cert.keyid())? .sign_subkey_binding(&mut pk.clone().into_keypair()?, &pk, &subkey)?; @@ -1536,8 +1534,6 @@ mod test { = key::Key4::generate_ecc(true, Curve::Ed25519)?.into(); let binding = signature::SignatureBuilder::new(SignatureType::SubkeyBinding) .set_key_flags(&KeyFlags::default().set_transport_encryption(true))? - .set_issuer_fingerprint(cert.fingerprint())? - .set_issuer(cert.keyid())? .sign_subkey_binding(&mut pk.clone().into_keypair()?, &pk, &subkey)?; @@ -1664,10 +1660,6 @@ mod test { // Create a signature. let sig = signature::SignatureBuilder::new(SignatureType::Binary) - .set_signature_creation_time( - std::time::SystemTime::now()).unwrap() - .set_issuer_fingerprint(key.fingerprint()).unwrap() - .set_issuer(key.keyid()).unwrap() .sign_message(&mut keypair, msg).unwrap(); // Make sure the signature is ok. |