openpgp: take ownership of KeyFlags bitfield

- Make `generate_key` polymorphic over `AsRef<KeyFlags>`.

- Since `set_key_flags` requires ownership of the key flags, it should
  take ownership rather than borrowing and cloning the them.
  See https://rust-lang.github.io/api-guidelines/flexibility.html#caller-decides-where-to-copy-and-place-data-c-caller-control .

- See #616.

1 files changed, 2 insertions, 2 deletions

diff --git a/openpgp/src/policy.rs b/openpgp/src/policy.rs
index 8a33a8c2..cc268d17 100644
--- a/openpgp/src/policy.rs
+++ b/openpgp/src/policy.rs
@@ -1511,7 +1511,7 @@ mod test {
         let subkey: key::SecretSubkey
             = Key4::generate_rsa(4096)?.into();
         let binding = signature::SignatureBuilder::new(SignatureType::SubkeyBinding)
-            .set_key_flags(&KeyFlags::empty().set_transport_encryption())?
+            .set_key_flags(KeyFlags::empty().set_transport_encryption())?
             .sign_subkey_binding(&mut pk.clone().into_keypair()?,
                                  pk.parts_as_public(), &subkey)?;
 
@@ -1534,7 +1534,7 @@ mod test {
         let subkey: key::SecretSubkey
             = key::Key4::generate_ecc(true, Curve::Ed25519)?.into();
         let binding = signature::SignatureBuilder::new(SignatureType::SubkeyBinding)
-            .set_key_flags(&KeyFlags::empty().set_transport_encryption())?
+            .set_key_flags(KeyFlags::empty().set_transport_encryption())?
             .sign_subkey_binding(&mut pk.clone().into_keypair()?,
                                  pk.parts_as_public(), &subkey)?;