diff options
| author | Nora Widdecke <nora@sequoia-pgp.org> | 2021-11-22 18:59:48 +0100 |
|---|---|---|
| committer | Nora Widdecke <nora@sequoia-pgp.org> | 2021-11-29 11:53:55 +0100 |
| commit | 192460a201a631a03e8e5a00469343fbe73fb437 (patch) | |
| tree | 309950ae109511a5e62391e8b3cf3591f79d6f39 /openpgp/src/packet | |
| parent | b2ffb4401fad2f5c51f35d56a4408c23c10a3450 (diff) | |
Prefer vec! macro.
- The vec![] macro is more performant and often easier to read than
multiple push calls.
- Allow push to a Vec straight after creation in tests. Performance
is not that great of an issue in tests, and the fix would impact
legibility.
- Found by clippy::vec_init_then_push.
Diffstat (limited to 'openpgp/src/packet')
| -rw-r--r-- | openpgp/src/packet/key.rs | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/openpgp/src/packet/key.rs b/openpgp/src/packet/key.rs index 6e75c604..ef49a291 100644 --- a/openpgp/src/packet/key.rs +++ b/openpgp/src/packet/key.rs @@ -1404,10 +1404,9 @@ assert_send_and_sync!(Unencrypted); impl From<mpi::SecretKeyMaterial> for Unencrypted { fn from(mpis: mpi::SecretKeyMaterial) -> Self { use crate::serialize::Marshal; - let mut plaintext = Vec::new(); // We need to store the type. - plaintext.push( - mpis.algo().unwrap_or(PublicKeyAlgorithm::Unknown(0)).into()); + let mut plaintext = + vec![mpis.algo().unwrap_or(PublicKeyAlgorithm::Unknown(0)).into()]; mpis.serialize(&mut plaintext) .expect("MPI serialization to vec failed"); Unencrypted { mpis: mem::Encrypted::new(plaintext.into()), } |