diff options
| author | Lars Wirzenius <liw@liw.fi> | 2021-09-20 19:26:48 +0300 |
|---|---|---|
| committer | Lars Wirzenius <liw@liw.fi> | 2021-09-21 09:56:49 +0300 |
| commit | 7febc9e2722f7ca97be91dc4a68c9f6a0502dc27 (patch) | |
| tree | 9159e67837902e39cd251c777f66c23789920ca2 /openpgp/src/fingerprint.rs | |
| parent | eff8edd82629a4e6151d4bcb104a7695c6975e8d (diff) | |
Avoid matching on &Foo, when a plain Foo pattern works
The extra & in a pattern (match arm or if let) is unnecessary and only
makes the code harder to read. In most places it's enough to just
remove the & from the pattern, but in a few places a dereference (*)
needs to be added where the value captured in the pattern is used, as
removing the & changes the type of the captured value to be a
reference.
Overall, the changes are almost mechanical. Although the diff is huge,
it should be easy to read.
The clippy lint match_ref_pats warns about this. See:
https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
Diffstat (limited to 'openpgp/src/fingerprint.rs')
| -rw-r--r-- | openpgp/src/fingerprint.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/openpgp/src/fingerprint.rs b/openpgp/src/fingerprint.rs index b7fbc3af..d60f3faa 100644 --- a/openpgp/src/fingerprint.rs +++ b/openpgp/src/fingerprint.rs @@ -141,8 +141,8 @@ impl Fingerprint { /// ``` pub fn as_bytes(&self) -> &[u8] { match self { - &Fingerprint::V4(ref fp) => fp, - &Fingerprint::Invalid(ref fp) => fp, + Fingerprint::V4(ref fp) => fp, + Fingerprint::Invalid(ref fp) => fp, } } @@ -233,8 +233,8 @@ impl Fingerprint { /// Common code for the above functions. fn convert_to_string(&self, pretty: bool) -> String { let raw = match self { - &Fingerprint::V4(ref fp) => &fp[..], - &Fingerprint::Invalid(ref fp) => &fp[..], + Fingerprint::V4(ref fp) => &fp[..], + Fingerprint::Invalid(ref fp) => &fp[..], }; // We currently only handle V4 fingerprints, which look like: |