openpgp: Introduce feature flag for quickcheck.

  - Make quickcheck dependency optional.

  - Make quickcheck a dev-dependency for tests.

  - Fix doctests for
    - cert::ValidCert::user_attributes,
    - cert::builder::CertBuilder::add_user_attribute,
    - cert::revoke::UserAttributeRevocationBuilder
    - cert::revoke::UserAttributeRevocationBuilder::build.
    Doctests do not use cfg(test), so we cannot use quickcheck in there.

1 files changed, 12 insertions, 8 deletions

diff --git a/openpgp/src/cert/builder.rs b/openpgp/src/cert/builder.rs
index 751abb55..4243cb2f 100644
--- a/openpgp/src/cert/builder.rs
+++ b/openpgp/src/cert/builder.rs
@@ -426,7 +426,7 @@ impl CertBuilder {
     /// primary User ID flag set:
     ///
     /// ```
-    /// # use quickcheck::{Arbitrary, StdThreadGen};
+    /// # use openpgp::packet::user_attribute::Subpacket;
     /// use sequoia_openpgp as openpgp;
     /// use openpgp::cert::prelude::*;
     /// use openpgp::packet::prelude::*;
@@ -434,9 +434,11 @@ impl CertBuilder {
     ///
     /// # fn main() -> openpgp::Result<()> {
     /// let p = &StandardPolicy::new();
-    ///
-    /// # let mut gen = StdThreadGen::new(16);
-    /// # let user_attribute : UserAttribute = UserAttribute::arbitrary(&mut gen);
+    /// #
+    /// # // Create some user attribute. Doctests do not pass cfg(test),
+    /// # // so UserAttribute::arbitrary is not available
+    /// # let sp = Subpacket::Unknown(7, vec![7; 7].into_boxed_slice());
+    /// # let user_attribute = UserAttribute::new(&[sp])?;
     ///
     /// let (cert, rev) =
     ///     CertBuilder::new()
@@ -455,7 +457,7 @@ impl CertBuilder {
     /// set:
     ///
     /// ```
-    /// # use quickcheck::{Arbitrary, StdThreadGen};
+    /// # use openpgp::packet::user_attribute::Subpacket;
     /// use sequoia_openpgp as openpgp;
     /// use openpgp::cert::prelude::*;
     /// use openpgp::packet::prelude::*;
@@ -463,9 +465,11 @@ impl CertBuilder {
     ///
     /// # fn main() -> openpgp::Result<()> {
     /// let p = &StandardPolicy::new();
-    ///
-    /// # let mut gen = StdThreadGen::new(16);
-    /// # let user_attribute : UserAttribute = UserAttribute::arbitrary(&mut gen);
+    /// #
+    /// # // Create some user attribute. Doctests do not pass cfg(test),
+    /// # // so UserAttribute::arbitrary is not available
+    /// # let sp = Subpacket::Unknown(7, vec![7; 7].into_boxed_slice());
+    /// # let user_attribute = UserAttribute::new(&[sp])?;
     ///
     /// let (cert, rev) =
     ///     CertBuilder::new()