openpgp: Make {is,possible}_{message,keyring,tpk} return a Result

  - PacketParserEOF::is_message, PacketParserEOF::is_keyring,
    PacketParserEOF::is_tpk, PacketParserResult::possible_message,
    PacketParserResult::possible_keyring, and
    PacketParserResult::possible_tpk returned a boolean.

  - Change them to return a Result<()> instead, which is more Rusty,
    and, in particular, allows the caller to determine why the message
    didn't parse.

1 files changed, 4 insertions, 2 deletions

diff --git a/openpgp-ffi/src/parse/mod.rs b/openpgp-ffi/src/parse/mod.rs
index 02fc4b27..df13bcbd 100644
--- a/openpgp-ffi/src/parse/mod.rs
+++ b/openpgp-ffi/src/parse/mod.rs
@@ -92,11 +92,13 @@ pub extern "C" fn pgp_packet_parser_free(pp: Option<&mut PacketParser>) {
 /// Frees the packet parser EOF object.
 #[::sequoia_ffi_macros::extern_fn] #[no_mangle]
 pub extern "C" fn pgp_packet_parser_eof_is_message(
+    errp: Option<&mut *mut ::error::Error>,
     eof: *const PacketParserEOF) -> bool
 {
+    ffi_make_fry_from_errp!(errp);
     let eof = ffi_param_ref!(eof);
-
-    eof.is_message()
+    ffi_try_or!(eof.is_message(), false);
+    true
 }
 
 /// Frees the packet parser EOF object.