openpgp: Warn about possible reallocation in mem::Protected

1 files changed, 3 insertions, 0 deletions

diff --git a/openpgp/src/crypto/mem.rs b/openpgp/src/crypto/mem.rs
index 6b2ed613..102f4db0 100644
--- a/openpgp/src/crypto/mem.rs
+++ b/openpgp/src/crypto/mem.rs
@@ -99,6 +99,9 @@ impl DerefMut for Protected {
 
 impl From<Vec<u8>> for Protected {
     fn from(v: Vec<u8>) -> Self {
+        // FIXME(xanewok): This can potentially realloc and leave a lingering
+        // copy of the secret somewhere. It'd be great to explicitly move the
+        // source data by copying it and zeroing it explicitly afterwards.
         Protected(v.into_boxed_slice())
     }
 }