openpgp: De-optimize crypto::random.

  - Previously, we used a thread-local cache of the Yarrow CPRNG
    state.  However, without fork(2)-detection this is not safe.  For
    now, just initialize a fresh one on every invocation.

1 files changed, 1 insertions, 3 deletions

diff --git a/openpgp/src/crypto/mod.rs b/openpgp/src/crypto/mod.rs
index 9b338f13..c93b3625 100644
--- a/openpgp/src/crypto/mod.rs
+++ b/openpgp/src/crypto/mod.rs
@@ -30,9 +30,7 @@ pub use self::asymmetric::{
 
 /// Fills the given buffer with random data.
 pub fn random<B: AsMut<[u8]>>(mut buf: B) {
-    use std::cell::RefCell;
-    thread_local!(static RNG: RefCell<Yarrow> = Default::default());
-    RNG.with(|rng| rng.borrow_mut().random(buf.as_mut()));
+    Yarrow::default().random(buf.as_mut());
 }
 
 /// Holds a session key.