summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2021-09-29 09:24:51 +0300
committerLars Wirzenius <liw@sequoia-pgp.org>2021-09-30 08:31:17 +0300
commit27c76208f5470651d46f77e16bb2e1b1c14f3a08 (patch)
tree35c87f90a69e43dfa2192095b34a9a5394d0c0f7
parentc8f7cba5f711666b411460fa5822e39ff5671d8a (diff)
Allow short single-character argument and variable names
Generally speaking, single-character names are not great for the person reading the code later. They don't usually act as a cognitive aid to understand the code. However, this in code implementing cryptographic operations that implements mathematical formulas that canonically use single-letter names it's clearer to use the same name in the code. Thus, I only tell clippy those names are OK in these cases. Found by clippy lint many_single_char_names: https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
-rw-r--r--openpgp/src/crypto/backend/nettle/asymmetric.rs1
-rw-r--r--openpgp/src/serialize/stream/padding.rs1
2 files changed, 2 insertions, 0 deletions
diff --git a/openpgp/src/crypto/backend/nettle/asymmetric.rs b/openpgp/src/crypto/backend/nettle/asymmetric.rs
index 71e9dfe3..bf1126e6 100644
--- a/openpgp/src/crypto/backend/nettle/asymmetric.rs
+++ b/openpgp/src/crypto/backend/nettle/asymmetric.rs
@@ -386,6 +386,7 @@ impl<R> Key4<SecretParts, R>
/// The RSA key will use public exponent `e` and modulo `n`. The key will
/// have it's creation date set to `ctime` or the current time if `None`
/// is given.
+ #[allow(clippy::many_single_char_names)]
pub fn import_secret_rsa<T>(d: &[u8], p: &[u8], q: &[u8], ctime: T)
-> Result<Self> where T: Into<Option<SystemTime>>
{
diff --git a/openpgp/src/serialize/stream/padding.rs b/openpgp/src/serialize/stream/padding.rs
index 6fa15f41..38ab804b 100644
--- a/openpgp/src/serialize/stream/padding.rs
+++ b/openpgp/src/serialize/stream/padding.rs
@@ -363,6 +363,7 @@ impl<'a> writer::Stackable<'a, Cookie> for Padder<'a>
/// [example].
///
/// [example]: Padder#examples
+#[allow(clippy::many_single_char_names)]
pub fn padme(l: u64) -> u64 {
if l < 2 {
return 1; // Avoid cornercase.