summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2021-09-21 15:45:00 +0300
committerLars Wirzenius <liw@sequoia-pgp.org>2021-09-30 08:31:02 +0300
commitd3c714befd119e1999df620b5f15f3ee5c873021 (patch)
tree3a8ce792ee80b0dd5dad528bedb1d8f55b309b1e
parent5ccc49ae6b711a926e6d1036b1c902c2bbb1d47a (diff)
Use std::mem::take instead of std::mem::replace, for clarity
Replace let bar = std::mem::replace(&foo, Default::Default()); with let bar = std::mem::take(&foo); The new version seems a little clearer. Found by clippy: https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default Sponsored-by: author
-rw-r--r--openpgp/src/cert/parser/mod.rs2
-rw-r--r--openpgp/src/parse/hashed_reader.rs3
2 files changed, 2 insertions, 3 deletions
diff --git a/openpgp/src/cert/parser/mod.rs b/openpgp/src/cert/parser/mod.rs
index d5f9b5e7..02516428 100644
--- a/openpgp/src/cert/parser/mod.rs
+++ b/openpgp/src/cert/parser/mod.rs
@@ -783,7 +783,7 @@ impl<'a> CertParser<'a> {
// Returns the old state. Note: the packet iterator is preserved.
fn reset(&mut self) -> Self {
// We need to preserve `source` and `filter`.
- let mut orig = mem::replace(self, Default::default());
+ let mut orig = mem::take(self);
self.source = orig.source.take();
mem::swap(&mut self.filter, &mut orig.filter);
orig
diff --git a/openpgp/src/parse/hashed_reader.rs b/openpgp/src/parse/hashed_reader.rs
index 7dc02a65..f4ee5964 100644
--- a/openpgp/src/parse/hashed_reader.rs
+++ b/openpgp/src/parse/hashed_reader.rs
@@ -370,8 +370,7 @@ pub(crate) fn hash_buffered_reader<R>(reader: R,
reader.drop_eof()?;
let hashes =
- mem::replace(&mut reader.cookie_mut().sig_group_mut().hashes,
- Default::default());
+ mem::take(&mut reader.cookie_mut().sig_group_mut().hashes);
Ok(hashes)
}