diff options
| author | Nora Widdecke <nora@sequoia-pgp.org> | 2021-11-25 19:20:34 +0100 |
|---|---|---|
| committer | Nora Widdecke <nora@sequoia-pgp.org> | 2021-11-29 11:53:56 +0100 |
| commit | 16f7b6f92eb918a9ad258ca012959f338ac7e5d2 (patch) | |
| tree | 5f1f34b541ecfb5600ba17b58b07b5ac7e3946df | |
| parent | f6a28555c2682c700165404d5f1944122b969f76 (diff) | |
Remove unnecessary conversions.
- Found with clippy::useless_conversion.
| -rw-r--r-- | openpgp/benches/common/decrypt.rs | 2 | ||||
| -rw-r--r-- | openpgp/src/cert.rs | 4 | ||||
| -rw-r--r-- | openpgp/src/crypto/backend/rust/asymmetric.rs | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/openpgp/benches/common/decrypt.rs b/openpgp/benches/common/decrypt.rs index 6f73e6d4..edb49c97 100644 --- a/openpgp/benches/common/decrypt.rs +++ b/openpgp/benches/common/decrypt.rs @@ -147,7 +147,7 @@ impl DecryptionHelper for CertHelper<'_> { .for_transport_encryption() .for_storage_encryption() .secret() - .map(|amalgamation| amalgamation.key().clone().into()) + .map(|amalgamation| amalgamation.key().clone()) .collect(); // check that pkesk has right recipient diff --git a/openpgp/src/cert.rs b/openpgp/src/cert.rs index 2e0e33ee..8d125e00 100644 --- a/openpgp/src/cert.rs +++ b/openpgp/src/cert.rs @@ -4264,7 +4264,7 @@ mod test { // Insert sig_a and sig_b. Make sure sig_b (and it alone) // appears. let cert2 = cert.clone().insert_packets( - vec![ sig_a.clone().into(), sig_b.clone() ])?; + vec![ sig_a.clone(), sig_b.clone() ])?; let mut sigs = cert2.primary_key().self_signatures(); assert_eq!(sigs.next(), Some(&sig_b)); assert!(sigs.next().is_none()); @@ -4273,7 +4273,7 @@ mod test { // Insert sig_b and sig_a. Make sure sig_a (and it alone) // appears. let cert2 = cert.clone().insert_packets( - vec![ sig_b.clone().into(), sig_a.clone() ])?; + vec![ sig_b.clone(), sig_a.clone() ])?; let mut sigs = cert2.primary_key().self_signatures(); assert_eq!(sigs.next(), Some(&sig_a)); assert!(sigs.next().is_none()); diff --git a/openpgp/src/crypto/backend/rust/asymmetric.rs b/openpgp/src/crypto/backend/rust/asymmetric.rs index cd3faee7..b0557279 100644 --- a/openpgp/src/crypto/backend/rust/asymmetric.rs +++ b/openpgp/src/crypto/backend/rust/asymmetric.rs @@ -528,7 +528,7 @@ impl<R> Key4<SecretParts, R> scalar: private_key.into(), }; - (PublicKeyAlgorithm::ECDH, public_mpis, private_mpis.into()) + (PublicKeyAlgorithm::ECDH, public_mpis, private_mpis) } (Curve::NistP256, true) => { @@ -546,7 +546,7 @@ impl<R> Key4<SecretParts, R> scalar: Vec::from(secret.to_bytes().as_slice()).into(), }; - (PublicKeyAlgorithm::ECDSA, public_mpis, private_mpis.into()) + (PublicKeyAlgorithm::ECDSA, public_mpis, private_mpis) }, (Curve::NistP256, false) => { @@ -566,7 +566,7 @@ impl<R> Key4<SecretParts, R> scalar: Vec::from(secret.to_bytes().as_slice()).into(), }; - (PublicKeyAlgorithm::ECDH, public_mpis, private_mpis.into()) + (PublicKeyAlgorithm::ECDH, public_mpis, private_mpis) }, _ => { |