diff options
author | Nora Widdecke <nora@sequoia-pgp.org> | 2021-04-07 22:45:44 +0200 |
---|---|---|
committer | Nora Widdecke <nora@sequoia-pgp.org> | 2021-04-09 13:14:00 +0200 |
commit | 8e95666b6613a4390a38e2cf86bd9ca6289938f9 (patch) | |
tree | 29b2afbf266a6e2b99192c0ea55d363e8e90d4a5 | |
parent | 792dfa2105e0a75a27ebffdc1cf0ab8873deaac1 (diff) |
Lint: Remove redundant clone().
- https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
-rw-r--r-- | net/src/wkd.rs | 12 | ||||
-rw-r--r-- | openpgp/src/cert/builder.rs | 2 | ||||
-rw-r--r-- | sq/src/commands/mod.rs | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/net/src/wkd.rs b/net/src/wkd.rs index 50f32206..84dc10dc 100644 --- a/net/src/wkd.rs +++ b/net/src/wkd.rs @@ -463,20 +463,20 @@ mod tests { .well-known/openpgpkey/example.com/hu/\ stnkabub89rpcphiz4ppbxixkwyt1pic?l=test1"; let wkd_url = Url::from("test1@example.com").unwrap(); - assert_eq!(expected_url, wkd_url.clone().to_string()); + assert_eq!(expected_url, wkd_url.to_string()); assert_eq!(url::Url::parse(expected_url).unwrap(), - wkd_url.clone().to_url(None).unwrap()); + wkd_url.to_url(None).unwrap()); assert_eq!(expected_url.parse::<Uri>().unwrap(), - wkd_url.clone().to_uri(None).unwrap()); + wkd_url.to_uri(None).unwrap()); // Direct method let expected_url = "https://example.com/\ .well-known/openpgpkey/hu/\ stnkabub89rpcphiz4ppbxixkwyt1pic?l=test1"; - assert_eq!(expected_url, wkd_url.clone().build(Direct)); + assert_eq!(expected_url, wkd_url.build(Direct)); assert_eq!(url::Url::parse(expected_url).unwrap(), - wkd_url.clone().to_url(Direct).unwrap()); + wkd_url.to_url(Direct).unwrap()); assert_eq!(expected_url.parse::<Uri>().unwrap(), wkd_url.to_uri(Direct).unwrap()); } @@ -489,7 +489,7 @@ mod tests { stnkabub89rpcphiz4ppbxixkwyt1pic"; let wkd_url = Url::from("test1@example.com").unwrap(); assert_eq!(expected_path, - wkd_url.clone().to_file_path(None).unwrap().to_str().unwrap()); + wkd_url.to_file_path(None).unwrap().to_str().unwrap()); // Direct method let expected_path = diff --git a/openpgp/src/cert/builder.rs b/openpgp/src/cert/builder.rs index d0147b99..05c3859e 100644 --- a/openpgp/src/cert/builder.rs +++ b/openpgp/src/cert/builder.rs @@ -997,7 +997,7 @@ impl CertBuilder<'_> { })); packets.push(sig.clone().into()); - let sig = signature::SignatureBuilder::from(sig.clone()) + let sig = signature::SignatureBuilder::from(sig) .set_signature_creation_time(creation_time)?; // Remove subpackets that needn't be copied into the binding diff --git a/sq/src/commands/mod.rs b/sq/src/commands/mod.rs index c216d35e..ee185be7 100644 --- a/sq/src/commands/mod.rs +++ b/sq/src/commands/mod.rs @@ -346,7 +346,7 @@ impl<'a> VerificationHelper for VHelper<'a> { }).collect(); // Explicitly provided keys are trusted. - self.trusted = seen.clone(); + self.trusted = seen; Ok(certs) } |