diff options
author | Yousif Akbar <11247449+yhakbar@users.noreply.github.com> | 2023-05-17 14:54:28 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-17 13:54:28 -0500 |
commit | 1d56bc897dafe96f0fc3192260a7332026187bca (patch) | |
tree | 2cade6e4a79223e8fe5c8a22bcb2b6521b2d0d31 | |
parent | b5768a7a4e404185fd5d4364a137a4de93e8fe1d (diff) |
Build Adjustments (#179)
* Adding extra compile targets
* Moving symbol stripping to cargo release build instead of doing it manually after the fact
* Removing Windows builds
* aarch64-apple-darwin build works better without cross
* Re-introducing windows builds, but commenting it out to signal future work
* Commenting out failing `aarch64-apple-darwin` test
* Adding failing 'x86_64-pc-windows-msvc` test back in as a comment
-rw-r--r-- | .github/workflows/publish.yml | 15 | ||||
-rw-r--r-- | .github/workflows/test.yml | 16 | ||||
-rw-r--r-- | Cargo.toml | 1 |
3 files changed, 22 insertions, 10 deletions
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 78abb3c..6a2158c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -24,9 +24,10 @@ jobs: target: arm-unknown-linux-gnueabihf use-cross: true - - os: windows-latest - target: x86_64-pc-windows-msvc - use-cross: false + # This isn't working right now. See this: https://github.com/chmln/sd/pull/179#discussion_r1195840367 + # - os: windows-latest + # target: x86_64-pc-windows-msvc + # use-cross: false - os: macos-latest target: x86_64-apple-darwin @@ -36,6 +37,10 @@ jobs: target: aarch64-apple-darwin use-cross: false + - os: ubuntu-latest + target: aarch64-unknown-linux-musl + use-cross: true + steps: - name: Checkout repository uses: actions/checkout@v2 @@ -62,10 +67,6 @@ jobs: command: build args: --target ${{ matrix.target }} --release --locked - - name: Strip binary - if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest' - run: strip target/${{ matrix.target }}/release/sd - - name: Upload binaries to release uses: svenstaro/upload-release-action@v1-release with: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index acd6608..443a11d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,14 +21,24 @@ jobs: target: arm-unknown-linux-gnueabihf use-cross: true - - os: windows-latest - target: x86_64-pc-windows-msvc - use-cross: false + # This isn't working right now. See this: https://github.com/chmln/sd/pull/179#discussion_r1195840870 + # - os: windows-latest + # target: x86_64-pc-windows-msvc + # use-cross: false - os: macos-latest target: x86_64-apple-darwin use-cross: false + # This isn't working right now. See this: https://github.com/chmln/sd/pull/179#discussion_r1195840870 + # - os: macos-latest + # target: aarch64-apple-darwin + # use-cross: false + + - os: ubuntu-latest + target: aarch64-unknown-linux-musl + use-cross: true + steps: - name: Checkout repository uses: actions/checkout@v2 @@ -36,3 +36,4 @@ man = "0.3.0" [profile.release] opt-level = 3 lto = true +strip = true |