From daa157b5f99c064eac7cd4593e4ec07bb8fd9bef Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Tue, 28 Nov 2023 16:14:22 -0500 Subject: core: actually implement --sortr=path This is an embarrassing oversight. A `todo!()` actually made its way into a release! Oof. This was working in ripgrep 13, but I had redone some aspects of sorting and this just got left undone. Fixes #2664 --- crates/core/flags/hiargs.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'crates') diff --git a/crates/core/flags/hiargs.rs b/crates/core/flags/hiargs.rs index 59a178e4..e027a2c9 100644 --- a/crates/core/flags/hiargs.rs +++ b/crates/core/flags/hiargs.rs @@ -771,7 +771,13 @@ impl HiArgs { let Some(ref sort) = self.sort else { return Box::new(haystacks) }; let mut with_timestamps: Vec<_> = match sort.kind { SortModeKind::Path if !sort.reverse => return Box::new(haystacks), - SortModeKind::Path => todo!(), + SortModeKind::Path => { + let mut haystacks = haystacks.collect::>(); + haystacks.sort_by(|ref h1, ref h2| { + h1.path().cmp(h2.path()).reverse() + }); + return Box::new(haystacks.into_iter()); + } SortModeKind::LastModified => { attach_timestamps(haystacks, |md| md.modified()).collect() } -- cgit v1.2.3