From 7ce66f73cf7e76e9f2557922ac8e650eb02cf4ed Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Sat, 12 Jun 2021 16:22:30 -0400 Subject: regex: update regression test Sadly, PCRE2 has different behavior (but doesn't panic). We should look into that, but for now, this is good enough. Also, update the CHANGELOG. Ref #1891 --- CHANGELOG.md | 9 +++++++-- tests/regression.rs | 7 +++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93d7d3e6..ae7e6315 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,12 @@ -TBD -=== +13.0.1 +====== Unreleased changes. Release notes have not yet been written. +Bug fixes: + +* [BUG #1891](https://github.com/BurntSushi/ripgrep/issues/1891): + Fix bug when using `-w` with a regex that can match the empty string. + 13.0.0 (2021-06-12) =================== diff --git a/tests/regression.rs b/tests/regression.rs index e35e953f..e6af26df 100644 --- a/tests/regression.rs +++ b/tests/regression.rs @@ -1032,6 +1032,13 @@ rgtest!(r1878, |dir: Dir, _: TestCommand| { // See: https://github.com/BurntSushi/ripgrep/issues/1891 rgtest!(r1891, |dir: Dir, mut cmd: TestCommand| { + // TODO: Sadly, PCRE2 has different behavior here. Not clear why. We should + // look into this and see if there's a fix needed at the regex engine + // level. + if dir.is_pcre2() { + return; + } + dir.create("test", "\n##\n"); // N.B. We use -o here to force the issue to occur, which seems to only // happen when each match needs to be detected. -- cgit v1.2.3