diff options
author | Andrew Gallant <jamslam@gmail.com> | 2018-04-23 19:57:22 -0400 |
---|---|---|
committer | Andrew Gallant <jamslam@gmail.com> | 2018-04-23 19:57:22 -0400 |
commit | ae6f8714912d522e8042701c30da43c6c667dfd3 (patch) | |
tree | 107c31e5239988888254622161660bf79d6bbb4c /tests | |
parent | ed059559cd465c32ee7b05b9ae46612c105a2bea (diff) |
output: remove --line-number-width flag
This commit does what no software project has ever done before: we've
outright removed a flag with no possible way to recapture its
functionality.
This flag presents numerous problems in that it never really worked well
in the first place, and completely falls over when ripgrep uses the
--no-heading output format. Well meaning users want ripgrep to fix this
by getting into the alignment business by buffering all output, but that
is a line that I refuse to cross.
Fixes #795
Diffstat (limited to 'tests')
-rw-r--r-- | tests/tests.rs | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/tests/tests.rs b/tests/tests.rs index c9fa002f..b1b972cf 100644 --- a/tests/tests.rs +++ b/tests/tests.rs @@ -107,22 +107,6 @@ sherlock!(line_numbers, |wd: WorkDir, mut cmd: Command| { assert_eq!(lines, expected); }); -sherlock!(line_number_width, |wd: WorkDir, mut cmd: Command| { - cmd.arg("-n"); - cmd.arg("--line-number-width").arg("2"); - let lines: String = wd.stdout(&mut cmd); - let expected = " 1:For the Doctor Watsons of this world, as opposed to the Sherlock - 3:be, to a very large extent, the result of luck. Sherlock Holmes -"; - assert_eq!(lines, expected); -}); - -sherlock!(line_number_width_padding_character_error, |wd: WorkDir, mut cmd: Command| { - cmd.arg("-n"); - cmd.arg("--line-number-width").arg("02"); - wd.assert_non_empty_stderr(&mut cmd); -}); - sherlock!(columns, |wd: WorkDir, mut cmd: Command| { cmd.arg("--column"); let lines: String = wd.stdout(&mut cmd); |