Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
|
|
Add license scan report and status
|
|
|
|
Signed-off-by: fossabot <badges@fossa.io>
|
|
|
|
Build system related fixes
|
|
Currently, the project resources are built twice: the first time in the
"main" directory and the second time in the "src" directory.
This is because they are specified both in main.pro and src.pro qmake
project files (and in qtpass.pro, too).
They should be specified in just one such project file instead so they
are built just once.
Let's leave them in src.pro since that's where localization *.ts -> *.qm
dependencies are provided.
For this, a Q_INIT_RESOURCE() statement is needed so they are properly
linked to by the main application.
|
|
Currently, if one changes some source file in src and then runs make the
libqtpass.a gets correctly rebuilt, however main/qtpass isn't actually
relinked to make use of this new library version.
According to the qmake project file snippet at the very bottom of
https://doc.qt.io/qtcreator/creator-project-qmake-libraries.html internal
static libraries need to be manually added to their users PRE_TARGETDEPS,
too.
The same goes for tests that link to libqtpass.a.
|
|
Having compiler_updateqm_make_all target in PRE_TARGETDEPS in src.pro
causes make to always consider libqtpass.a out of date and rebuild it.
Together with the next commit this will cause main/qtpass to always be
considered out of date and so relinked unnecessarily on each make
invocation.
It looks like this PRE_TARGETDEPS entry isn't actually required as qmake
generates proper localization/*.ts -> localization/*.qm dependencies
without it anyway, so let's just remove it.
|
|
(At least) Linux uses tests/auto/ui/tst_ui and tests/auto/util/tst_util
as output file names for built tests, so add these names to .gitignore so
they don't pop up as untracked files.
|
|
Commits 29e65d7208da06 ("Fix html links color and NL translation building error")
and df43cec8642813 ("Localization normalized and minor (auto) updates")
removed localization/localization_nl.ts file from the source tree and
qtpass resources but forgot to remove it from qtpass.pro so it got
automatically recreated (nearly empty) every time qmake was run.
Remove it from this file, too.
|
|
localization/*.ts files are XML (data) files, there is no need for them to
be marked executable, but two of them were.
|
|
|
|
|
|
|
|
Add missing overrides
|
|
maciejsszmigiero/main-window-entry-details-improvements
Main window entry details improvements
|
|
|
|
|
|
Knowing the TOTP secret for a password entry allows somebody to recreate
the whole OTP sequence so it definitely shouldn't be displayed in the
clear.
In fact, it shouldn't be displayed at all in the main window since the
proper way to utilize a TOTP entry is to click the "OTP" button to generate
a new OTP (rather than to copy the secret to the clipboard like it was a
password).
The password edit dialog isn't affected by this change and will still show
the whole entry, including its TOTP secret if present.
|
|
Commit 3cb140ca697367 ("Trying to use QtPass as process handler and connector for Pass")
removed a DisplayInTextBrowser() call from MainWindow::passShowHandler()
and added a similar QtPass::showInTextBrowser() function that is invoked by
QtPass::passShowHandlerFinished() slot.
This slot is in turn connected to MainWindow::passShowHandlerFinished
signal which wasn't emitted anywhere in the code.
Emit it where the old DisplayInTextBrowser() call was so password entry
non-template details are actually displayed upon selecting it in the main
QtPass window.
|
|
QtPass::connectPassSignalHandlers() will be called twice, the first time
for the real pass and the second time for a pass imitator.
This means that we can't connect MainWindow::passShowHandlerFinished signal
in this function or it will be connected (and so then invoked) twice.
Connect it in the QtPass::connectPassSignalHandlers() single caller
instead.
|
|
|
|
|
|
Fix html links color and NL translation building error
|
|
|
|
|
|
Restore directories-first order of passwords tree view on non-Mac platforms
|
|
|
|
Since commit b4dc9e69e7c553 ("Auto update CHANGELOG and sorting of treeview")
directories are no longer listed first in the tree view of passwords.
This is because a simple sort of the tree view widget (as enabled by the
aforementioned commit) does its work by sorting the backing
StoreModel (QSortFilterProxyModel), which in turn does just a simple
lexicographical order sort on the path of each its item.
Before that commit the sort was done by QFileSystemModel via
QFileSystemModelSorter, which always places its directories first on
non-Mac platforms.
Unfortunately, QFileSystemModelSorter is an internal Qt helper class, so we
can't just use it directly, we need to open-code a bit of logic from
QFileSystemModelSorter::compareNodes() into StoreModel::lessThan() to
restore the old behavior.
|
|
|
|
When we are setting the source model in StoreModel::setModelAndStore() set
it also for StoreModel base class to make the extra setSourceModel() call
unnecessary.
|
|
|
|
|
|
Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function)
|
|
Commit 990b89c0ee6231 ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.
However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.
See:
https://github.com/IJHack/QtPass/issues/423
https://github.com/IJHack/QtPass/issues/465
https://github.com/IJHack/QtPass/issues/470
|
|
|
|
|
|
into Noettore-feature/renameEntry
|
|
Sorted profiles dropdown as in #404
|
|
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
|
|
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
|
|
Signed-off-by: Ettore Dreucci <ettore.dreucci@gmail.com>
|
|
Signed-off-by: Ettore <noettore@gmail.com>
|
|
Fix missing app ID and icon on Wayland.
|