summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAnne Jan Brouwer <brouwer@annejan.com>2018-04-29 15:49:49 +0200
committerAnne Jan Brouwer <brouwer@annejan.com>2018-04-29 15:49:49 +0200
commit9b9aa681a42c4255bd7669098b34069e1fdd00f5 (patch)
tree0476940244b5708d09a62c4abff538863ba73afe /src
parent04658fa20bb60f9ccab80a378d04a31b82adcd4e (diff)
Some tips from codefactor
Diffstat (limited to 'src')
-rw-r--r--src/mainwindow.cpp2
-rw-r--r--src/pass.cpp1
-rw-r--r--src/passworddialog.cpp3
-rw-r--r--src/passworddialog.h2
-rw-r--r--src/realpass.h1
-rw-r--r--src/settingsconstants.h1
-rw-r--r--src/simpletransaction.h1
-rw-r--r--src/storemodel.h1
8 files changed, 4 insertions, 8 deletions
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index f0f8ced5..743dba45 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -168,7 +168,6 @@ void MainWindow::changeEvent(QEvent *event) {
* @param pass pointer to pass instance
*/
void MainWindow::connectPassSignalHandlers(Pass *pass) {
-
// TODO(bezet): this is never emitted(should be), also naming(see
// critical())
connect(pass, &Pass::error, this, &MainWindow::processError);
@@ -597,7 +596,6 @@ void MainWindow::finishedInsert(const QString &p_output,
void MainWindow::DisplayInTextBrowser(QString output, QString prefix,
QString postfix) {
-
output.replace(QRegExp("<"), "&lt;");
output.replace(QRegExp(">"), "&gt;");
output.replace(QRegExp(" "), "&nbsp;");
diff --git a/src/pass.cpp b/src/pass.cpp
index d8aaff8d..99216c54 100644
--- a/src/pass.cpp
+++ b/src/pass.cpp
@@ -163,7 +163,6 @@ QList<UserInfo> Pass::listKeys(QString keystring, bool secret) {
*/
void Pass::finished(int id, int exitCode, const QString &out,
const QString &err) {
-
PROCESS pid = static_cast<PROCESS>(id);
if (exitCode != 0) {
emit processErrorExit(exitCode, err);
diff --git a/src/passworddialog.cpp b/src/passworddialog.cpp
index 23768dae..059e8bd5 100644
--- a/src/passworddialog.cpp
+++ b/src/passworddialog.cpp
@@ -51,7 +51,8 @@ PasswordDialog::PasswordDialog(const QString &file, const bool &isNew,
setLength(m_passConfig.length);
setPasswordCharTemplate(m_passConfig.selected);
- connect(QtPassSettings::getPass(), &Pass::processErrorExit, this, &PasswordDialog::close);
+ connect(QtPassSettings::getPass(), &Pass::processErrorExit, this,
+ &PasswordDialog::close);
connect(this, &PasswordDialog::accepted, this, &PasswordDialog::on_accepted);
connect(this, &PasswordDialog::rejected, this, &PasswordDialog::on_rejected);
}
diff --git a/src/passworddialog.h b/src/passworddialog.h
index ca37afd4..7b69b350 100644
--- a/src/passworddialog.h
+++ b/src/passworddialog.h
@@ -1,8 +1,8 @@
#ifndef PASSWORDDIALOG_H_
#define PASSWORDDIALOG_H_
-#include <QDialog>
#include "passwordconfiguration.h"
+#include <QDialog>
namespace Ui {
class PasswordDialog;
diff --git a/src/realpass.h b/src/realpass.h
index dd2c38b7..2c17a0f2 100644
--- a/src/realpass.h
+++ b/src/realpass.h
@@ -8,7 +8,6 @@
\brief Wrapper for executing pass to handle the password-store
*/
class RealPass : public Pass {
-
void executePass(PROCESS id, const QStringList &arg,
QString input = QString(), bool readStdout = true,
bool readStderr = true);
diff --git a/src/settingsconstants.h b/src/settingsconstants.h
index 656cc4fe..0f436085 100644
--- a/src/settingsconstants.h
+++ b/src/settingsconstants.h
@@ -8,7 +8,6 @@
\brief Table for the naming of configuration items
*/
class SettingsConstants {
-
public:
const static QString version;
const static QString groupMainwindow;
diff --git a/src/simpletransaction.h b/src/simpletransaction.h
index c61a241a..93c7abbd 100644
--- a/src/simpletransaction.h
+++ b/src/simpletransaction.h
@@ -5,7 +5,6 @@
#include <queue>
class simpleTransaction {
-
int transactionDepth;
Enums::PROCESS lastInTransaction;
std::queue<std::pair<Enums::PROCESS, Enums::PROCESS>> transactionQueue;
diff --git a/src/storemodel.h b/src/storemodel.h
index 175132b2..66486b10 100644
--- a/src/storemodel.h
+++ b/src/storemodel.h
@@ -11,6 +11,7 @@
class QFileSystemModel;
class StoreModel : public QSortFilterProxyModel {
Q_OBJECT
+
private:
QFileSystemModel *fs;
QString store;