diff options
| author | Maciej S. Szmigiero <mail@maciej.szmigiero.name> | 2019-09-08 17:53:14 +0200 |
|---|---|---|
| committer | Maciej S. Szmigiero <mail@maciej.szmigiero.name> | 2019-09-08 17:53:36 +0200 |
| commit | b42dc5dcacc0cf07ab870032ad9652e6dc8b7d7b (patch) | |
| tree | cfbf5d2197579644605d839315f85213f3465b49 | |
| parent | 87217d3be810320cbaf3fa0b1bd22ca29f87c59b (diff) | |
Add missing finishedShow() signal connection in PasswordDialog constructor
Commit 990b89c0ee6231 ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.
However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.
See:
https://github.com/IJHack/QtPass/issues/423
https://github.com/IJHack/QtPass/issues/465
https://github.com/IJHack/QtPass/issues/470
| -rw-r--r-- | src/passworddialog.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/passworddialog.cpp b/src/passworddialog.cpp index ca3b5244..747d2787 100644 --- a/src/passworddialog.cpp +++ b/src/passworddialog.cpp @@ -58,6 +58,8 @@ PasswordDialog::PasswordDialog(const QString &file, const bool &isNew, setLength(m_passConfig.length); setPasswordCharTemplate(m_passConfig.selected); + connect(QtPassSettings::getPass(), &Pass::finishedShow, this, + &PasswordDialog::setPass); connect(QtPassSettings::getPass(), &Pass::processErrorExit, this, &PasswordDialog::close); connect(this, &PasswordDialog::accepted, this, &PasswordDialog::on_accepted); |