From af788ad6c3624ccc4b49778a9ded2487b9dbeedd Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 25 Feb 2022 13:37:08 +1100 Subject: fetch: convert a NULL property query to "" Previously, a NULL property query was never cached and this lead to a performance degregation. Now, such a query is converted to an empty string and cached. Fixes #17752 Fixes https://github.openssl.org/openssl/openssl/issues/26 Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/17769) --- doc/internal/man3/OSSL_METHOD_STORE.pod | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/internal') diff --git a/doc/internal/man3/OSSL_METHOD_STORE.pod b/doc/internal/man3/OSSL_METHOD_STORE.pod index 5d9219fd0e..e0536edff3 100644 --- a/doc/internal/man3/OSSL_METHOD_STORE.pod +++ b/doc/internal/man3/OSSL_METHOD_STORE.pod @@ -102,6 +102,12 @@ The I function is called to increment the reference count of the method and the I function is called to decrement it. +=head1 NOTES + +The I argument to ossl_method_store_cache_get() and +ossl_method_store_cache_set() is not allowed to be NULL. Use "" for an +empty property definition or query. + =head1 RETURN VALUES ossl_method_store_new() returns a new method store object or NULL on failure. -- cgit v1.2.3