From 3f968ecf479ed6ab8a2b25bd1077300baf2287a7 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Thu, 1 Dec 2022 14:16:02 +0000 Subject: Don't raise an error on retryable read in a BIO_s_dgram_pair() This results in spurious errors appearing on the queue in normal operation, e.g. calling SSL_tick() with a QUIC connection will succeed, but an error will end up on the queue anyway. Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/20030) --- crypto/bio/bss_dgram_pair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'crypto') diff --git a/crypto/bio/bss_dgram_pair.c b/crypto/bio/bss_dgram_pair.c index 3685d51f55..b80fa62e48 100644 --- a/crypto/bio/bss_dgram_pair.c +++ b/crypto/bio/bss_dgram_pair.c @@ -1066,12 +1066,10 @@ static int dgram_pair_recvmmsg(BIO *bio, BIO_MSG *msg, m->local, m->peer, 1); if (l < 0) { *num_processed = i; - if (i > 0) { + if (i > 0) ret = 1; - } else { - ERR_raise(ERR_LIB_BIO, -l); + else ret = 0; - } goto out; } -- cgit v1.2.3