From 68efafc513788863339c199d22048ef275832094 Mon Sep 17 00:00:00 2001 From: FdaSilvaYY Date: Mon, 27 Jun 2016 21:57:58 +0200 Subject: Add checks on sk_TYPE_push() returned value Reviewed-by: Rich Salz Reviewed-by: Matt Caswell --- crypto/ui/ui_lib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'crypto/ui/ui_lib.c') diff --git a/crypto/ui/ui_lib.c b/crypto/ui/ui_lib.c index 2940b2fd4a..8992ae77c2 100644 --- a/crypto/ui/ui_lib.c +++ b/crypto/ui/ui_lib.c @@ -127,8 +127,10 @@ static int general_allocate_string(UI *ui, const char *prompt, s->_.string_data.test_buf = test_buf; ret = sk_UI_STRING_push(ui->strings, s); /* sk_push() returns 0 on error. Let's adapt that */ - if (ret <= 0) + if (ret <= 0) { ret--; + free_string(s); + } } else free_string(s); } @@ -172,8 +174,10 @@ static int general_allocate_boolean(UI *ui, /* * sk_push() returns 0 on error. Let's adapt that */ - if (ret <= 0) + if (ret <= 0) { ret--; + free_string(s); + } } else free_string(s); } -- cgit v1.2.3