From 5cbd2ea3f94aa8adec9b4486ac757d4d688e3f8c Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 28 May 2021 14:46:40 +1000 Subject: add zero strenght arguments to BN and RAND RNG calls Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/15513) --- crypto/ffc/ffc_key_generate.c | 2 +- crypto/ffc/ffc_params_generate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'crypto/ffc') diff --git a/crypto/ffc/ffc_key_generate.c b/crypto/ffc/ffc_key_generate.c index d8d2116ddc..61a4a7427d 100644 --- a/crypto/ffc/ffc_key_generate.c +++ b/crypto/ffc/ffc_key_generate.c @@ -45,7 +45,7 @@ int ossl_ffc_generate_private_key(BN_CTX *ctx, const FFC_PARAMS *params, do { /* Steps (3, 4 & 7) : c + 1 = 1 + random[0..2^N - 1] */ - if (!BN_priv_rand_range_ex(priv, two_powN, ctx) + if (!BN_priv_rand_range_ex(priv, two_powN, 0, ctx) || !BN_add_word(priv, 1)) goto err; /* Step (6) : loop if c > M - 2 (i.e. c + 1 >= M) */ diff --git a/crypto/ffc/ffc_params_generate.c b/crypto/ffc/ffc_params_generate.c index 26ab9120c6..3c6f789c3e 100644 --- a/crypto/ffc/ffc_params_generate.c +++ b/crypto/ffc/ffc_params_generate.c @@ -329,7 +329,7 @@ static int generate_q_fips186_4(BN_CTX *ctx, BIGNUM *q, const EVP_MD *evpmd, /* A.1.1.2 Step (5) : generate seed with size seed_len */ if (generate_seed - && RAND_bytes_ex(libctx, seed, (int)seedlen) < 0) + && RAND_bytes_ex(libctx, seed, (int)seedlen, 0) < 0) goto err; /* * A.1.1.2 Step (6) AND @@ -399,7 +399,7 @@ static int generate_q_fips186_2(BN_CTX *ctx, BIGNUM *q, const EVP_MD *evpmd, if (!BN_GENCB_call(cb, 0, m++)) goto err; - if (generate_seed && RAND_bytes_ex(libctx, seed, (int)qsize) <= 0) + if (generate_seed && RAND_bytes_ex(libctx, seed, (int)qsize, 0) <= 0) goto err; memcpy(buf, seed, qsize); -- cgit v1.2.3