From ce1415ed2ce15305356cd028bcf7b9bc688d6d5c Mon Sep 17 00:00:00 2001 From: Shane Lontis Date: Tue, 19 Mar 2019 09:58:09 +1000 Subject: Added NULL check to BN_clear() & BN_CTX_end() Reviewed-by: Paul Dale Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/8518) --- crypto/ec/ecp_smpl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'crypto/ec/ecp_smpl.c') diff --git a/crypto/ec/ecp_smpl.c b/crypto/ec/ecp_smpl.c index f80f98a169..2fd2ce46ea 100644 --- a/crypto/ec/ecp_smpl.c +++ b/crypto/ec/ecp_smpl.c @@ -307,8 +307,7 @@ int ec_GFp_simple_group_check_discriminant(const EC_GROUP *group, BN_CTX *ctx) ret = 1; err: - if (ctx != NULL) - BN_CTX_end(ctx); + BN_CTX_end(ctx); BN_CTX_free(new_ctx); return ret; } @@ -787,8 +786,7 @@ int ec_GFp_simple_add(const EC_GROUP *group, EC_POINT *r, const EC_POINT *a, ret = 1; end: - if (ctx) /* otherwise we already called BN_CTX_end */ - BN_CTX_end(ctx); + BN_CTX_end(ctx); BN_CTX_free(new_ctx); return ret; } -- cgit v1.2.3