From 766a7d4676f08f815dd5070409e94954f4b64c6c Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 1 Apr 2022 09:33:17 +1100 Subject: Fix Coverity 1498612 & 1503221: integer overflow Both are the same issue and both as false positives. Annotate the line so that this is ignored. Reviewed-by: Tomas Mraz Reviewed-by: Bernd Edlinger (Merged from https://github.com/openssl/openssl/pull/18012) --- crypto/ec/curve448/curve448.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'crypto/ec/curve448') diff --git a/crypto/ec/curve448/curve448.c b/crypto/ec/curve448/curve448.c index 4db72cd28d..2fbeb45612 100644 --- a/crypto/ec/curve448/curve448.c +++ b/crypto/ec/curve448/curve448.c @@ -586,9 +586,15 @@ static int recode_wnaf(struct smvt_control *control, int32_t delta = odd & mask; assert(position >= 0); - assert(pos < 32); /* can't fail since current & 0xFFFF != 0 */ if (odd & (1 << (table_bits + 1))) delta -= (1 << (table_bits + 1)); + /* + * Coverity gets confused by the value of pos, thinking it might be + * 32. This would require current & 0xFFFF to be zero which isn't + * possible. Suppress this false positive, since adding a check + * isn't desirable. + */ + /* coverity[overflow_before_widen] */ current -= delta * (1 << pos); control[position].power = pos + 16 * (w - 1); control[position].addend = delta; -- cgit v1.2.3