From 0c9de428ae03a3dd9272aba90c595f6c25a4525d Mon Sep 17 00:00:00 2001 From: "Dr. Stephen Henson" Date: Sat, 23 Jun 2001 23:07:34 +0000 Subject: In {RSA,DSA,DH}_new_method(x) need to increase the reference count of the ENGINE is x is not NULL since it will be freed in {RSA,DSA,DH}_free(). --- crypto/dsa/dsa_lib.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) (limited to 'crypto/dsa') diff --git a/crypto/dsa/dsa_lib.c b/crypto/dsa/dsa_lib.c index 1b33705f46..48b228f3a1 100644 --- a/crypto/dsa/dsa_lib.c +++ b/crypto/dsa/dsa_lib.c @@ -146,17 +146,24 @@ DSA *DSA_new_method(ENGINE *engine) DSAerr(DSA_F_DSA_NEW,ERR_R_MALLOC_FAILURE); return(NULL); } - if(engine) - ret->engine = engine; + + if (engine) + { + if(ENGINE_init(engine)) + ret->engine = engine; + else + ret->engine = NULL; + } else + ret->engine=ENGINE_get_default_DSA(); + + if(ret->engine == NULL) { - if((ret->engine=ENGINE_get_default_DSA()) == NULL) - { - DSAerr(DSA_F_DSA_NEW,ERR_LIB_ENGINE); - OPENSSL_free(ret); - return NULL; - } + DSAerr(DSA_F_DSA_NEW,ERR_LIB_ENGINE); + OPENSSL_free(ret); + return NULL; } + meth = ENGINE_get_DSA(ret->engine); ret->pad=0; ret->version=0; -- cgit v1.2.3