From a21314dbbc56cd30580123d74b3106a628540965 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Mon, 17 Feb 2020 12:17:53 +1000 Subject: Also check for errors in x86_64-xlate.pl. In https://github.com/openssl/openssl/pull/10883, I'd meant to exclude the perlasm drivers since they aren't opening pipes and do not particularly need it, but I only noticed x86_64-xlate.pl, so arm-xlate.pl and ppc-xlate.pl got the change. That seems to have been fine, so be consistent and also apply the change to x86_64-xlate.pl. Checking for errors is generally a good idea. Reviewed-by: Richard Levitte Reviewed-by: David Benjamin (Merged from https://github.com/openssl/openssl/pull/10930) --- crypto/chacha/asm/chacha-armv4.pl | 2 +- crypto/chacha/asm/chacha-armv8.pl | 2 +- crypto/chacha/asm/chacha-c64xplus.pl | 2 +- crypto/chacha/asm/chacha-ia64.pl | 2 +- crypto/chacha/asm/chacha-ppc.pl | 2 +- crypto/chacha/asm/chacha-x86.pl | 2 +- crypto/chacha/asm/chacha-x86_64.pl | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) (limited to 'crypto/chacha') diff --git a/crypto/chacha/asm/chacha-armv4.pl b/crypto/chacha/asm/chacha-armv4.pl index 021da300ee..665ca50cf5 100755 --- a/crypto/chacha/asm/chacha-armv4.pl +++ b/crypto/chacha/asm/chacha-armv4.pl @@ -1166,4 +1166,4 @@ foreach (split("\n",$code)) { print $_,"\n"; } -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/chacha/asm/chacha-armv8.pl b/crypto/chacha/asm/chacha-armv8.pl index 466de51867..368e7ac834 100755 --- a/crypto/chacha/asm/chacha-armv8.pl +++ b/crypto/chacha/asm/chacha-armv8.pl @@ -1289,4 +1289,4 @@ foreach (split("\n",$code)) { print $_,"\n"; } -close STDOUT or die "error closing STDOUT"; # flush +close STDOUT or die "error closing STDOUT: $!"; # flush diff --git a/crypto/chacha/asm/chacha-c64xplus.pl b/crypto/chacha/asm/chacha-c64xplus.pl index 0b146288f7..6888e12da0 100755 --- a/crypto/chacha/asm/chacha-c64xplus.pl +++ b/crypto/chacha/asm/chacha-c64xplus.pl @@ -922,4 +922,4 @@ $code.=<<___; ___ print $code; -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/chacha/asm/chacha-ia64.pl b/crypto/chacha/asm/chacha-ia64.pl index 9276dd0fbf..b13d972855 100644 --- a/crypto/chacha/asm/chacha-ia64.pl +++ b/crypto/chacha/asm/chacha-ia64.pl @@ -288,4 +288,4 @@ stringz "ChaCha20 for IA64, CRYPTOGAMS by \@dot-asm" ___ print $code; -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/chacha/asm/chacha-ppc.pl b/crypto/chacha/asm/chacha-ppc.pl index c9c4343517..12e76b000a 100755 --- a/crypto/chacha/asm/chacha-ppc.pl +++ b/crypto/chacha/asm/chacha-ppc.pl @@ -1349,4 +1349,4 @@ foreach (split("\n",$code)) { print $_,"\n"; } -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/chacha/asm/chacha-x86.pl b/crypto/chacha/asm/chacha-x86.pl index 6cf6968890..24c6966d3e 100755 --- a/crypto/chacha/asm/chacha-x86.pl +++ b/crypto/chacha/asm/chacha-x86.pl @@ -1151,4 +1151,4 @@ sub XOPROUND { &asm_finish(); -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/chacha/asm/chacha-x86_64.pl b/crypto/chacha/asm/chacha-x86_64.pl index 25140104ce..1d67b87780 100755 --- a/crypto/chacha/asm/chacha-x86_64.pl +++ b/crypto/chacha/asm/chacha-x86_64.pl @@ -4004,4 +4004,4 @@ foreach (split("\n",$code)) { print $_,"\n"; } -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; -- cgit v1.2.3