From 858d5ac16d256db24f78b8c84e723b7d34c8b1ea Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Wed, 8 Dec 2021 18:26:03 +0100 Subject: bn2binpad: Use memset as the buffer will be used later Apparently using OPENSSL_cleanse() confuses the fuzzer so it makes the buffer to appear uninitialized. And memset can be safely used here and it is also potentially faster. Fixes #17237 Reviewed-by: Bernd Edlinger (Merged from https://github.com/openssl/openssl/pull/17240) --- crypto/bn/bn_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'crypto/bn/bn_lib.c') diff --git a/crypto/bn/bn_lib.c b/crypto/bn/bn_lib.c index 28a3e91679..d37b89c2a6 100644 --- a/crypto/bn/bn_lib.c +++ b/crypto/bn/bn_lib.c @@ -505,7 +505,8 @@ int bn2binpad(const BIGNUM *a, unsigned char *to, int tolen, endianess_t endiane /* Swipe through whole available data and don't give away padded zero. */ atop = a->dmax * BN_BYTES; if (atop == 0) { - OPENSSL_cleanse(to, tolen); + if (tolen != 0) + memset(to, '\0', tolen); return tolen; } -- cgit v1.2.3