From da2d32f6db1c9fb33478af660daddcd1df369716 Mon Sep 17 00:00:00 2001 From: Pauli Date: Mon, 13 Jan 2020 13:02:45 +1000 Subject: Deprecate the low level IDEA functions. Use of the low level IDEA functions has been informally discouraged for a long time. We now formally deprecate them. Applications should instead use the EVP APIs, e.g. EVP_EncryptInit_ex, EVP_EncryptUpdate, EVP_EncryptFinal_ex, and the equivalently named decrypt functions. Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/10819) --- apps/speed.c | 10 +++++----- apps/version.c | 12 ------------ 2 files changed, 5 insertions(+), 17 deletions(-) (limited to 'apps') diff --git a/apps/speed.c b/apps/speed.c index dd07527cde..4883fe0936 100644 --- a/apps/speed.c +++ b/apps/speed.c @@ -378,7 +378,7 @@ static const OPT_PAIR doit_choices[] = { {"rc5-cbc", D_CBC_RC5}, {"rc5", D_CBC_RC5}, #endif -#ifndef OPENSSL_NO_IDEA +#if !defined(OPENSSL_NO_IDEA) && !defined(OPENSSL_NO_DEPRECATED_3_0) {"idea-cbc", D_CBC_IDEA}, {"idea", D_CBC_IDEA}, #endif @@ -1459,7 +1459,7 @@ int speed_main(int argc, char **argv) #if !defined(OPENSSL_NO_RC2) && !defined(OPENSSL_NO_DEPRECATED_3_0) RC2_KEY rc2_ks; #endif -#ifndef OPENSSL_NO_IDEA +#if !defined(OPENSSL_NO_IDEA) && !defined(OPENSSL_NO_DEPRECATED_3_0) IDEA_KEY_SCHEDULE idea_ks; #endif #if !defined(OPENSSL_NO_SEED) && !defined(OPENSSL_NO_DEPRECATED_3_0) @@ -1969,7 +1969,7 @@ int speed_main(int argc, char **argv) Camellia_set_key(key32, 256, &camellia_ks[2]); } #endif -#ifndef OPENSSL_NO_IDEA +#if !defined(OPENSSL_NO_IDEA) && !defined(OPENSSL_NO_DEPRECATED_3_0) if (doit[D_CBC_IDEA]) IDEA_set_encrypt_key(key16, &idea_ks); #endif @@ -2571,7 +2571,7 @@ int speed_main(int argc, char **argv) } } #endif -#ifndef OPENSSL_NO_IDEA +#if !defined(OPENSSL_NO_IDEA) && !defined(OPENSSL_NO_DEPRECATED_3_0) if (doit[D_CBC_IDEA]) { if (async_jobs > 0) { BIO_printf(bio_err, "Async mode is not supported with %s\n", @@ -3507,7 +3507,7 @@ int speed_main(int argc, char **argv) #ifndef OPENSSL_NO_DEPRECATED_3_0 printf("%s ", AES_options()); #endif -#ifndef OPENSSL_NO_IDEA +#if !defined(OPENSSL_NO_IDEA) && !defined(OPENSSL_NO_DEPRECATED_3_0) printf("%s ", IDEA_options()); #endif #if !defined(OPENSSL_NO_BF) && !defined(OPENSSL_NO_DEPRECATED_3_0) diff --git a/apps/version.c b/apps/version.c index deb9133855..513bbc81af 100644 --- a/apps/version.c +++ b/apps/version.c @@ -15,18 +15,9 @@ #include #include #include -#ifndef OPENSSL_NO_MD2 -# include -#endif #ifndef OPENSSL_NO_DES # include #endif -#ifndef OPENSSL_NO_IDEA -# include -#endif -#ifndef OPENSSL_NO_BF -# include -#endif typedef enum OPTION_choice { OPT_ERR = -1, OPT_EOF = 0, OPT_HELP, @@ -128,9 +119,6 @@ opthelp: printf(" %s", BN_options()); #ifndef OPENSSL_NO_DES printf(" %s", DES_options()); -#endif -#ifndef OPENSSL_NO_IDEA - printf(" %s", IDEA_options()); #endif printf("\n"); } -- cgit v1.2.3