From 9fd6f7d1cd2a3c8e2bc69dcb8bde8406eb6c2623 Mon Sep 17 00:00:00 2001 From: Dmitry Belyavskiy Date: Mon, 8 Jul 2019 20:14:50 +1000 Subject: Avoid NULL pointer dereference. Fixes #9043. Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/9059) --- apps/req.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'apps') diff --git a/apps/req.c b/apps/req.c index ae420d30f5..f11d341c12 100644 --- a/apps/req.c +++ b/apps/req.c @@ -933,9 +933,19 @@ int req_main(int argc, char **argv) if (text) { if (x509) - X509_print_ex(out, x509ss, get_nameopt(), reqflag); + ret = X509_print_ex(out, x509ss, get_nameopt(), reqflag); else - X509_REQ_print_ex(out, req, get_nameopt(), reqflag); + ret = X509_REQ_print_ex(out, req, get_nameopt(), reqflag); + + if (ret == 0) { + if (x509) + BIO_printf(bio_err, "Error printing certificate\n"); + else + BIO_printf(bio_err, "Error printing certificate request\n"); + + ERR_print_errors(bio_err); + goto end; + } } if (subject) { -- cgit v1.2.3