From 033585175485077bf7f5bbb352fd4f162d0c235f Mon Sep 17 00:00:00 2001 From: Kurt Roeckx Date: Sun, 14 Feb 2016 20:45:02 +0100 Subject: argv was set but unused Also gives an error message when you gave it a parameter it didn't expect. Reviewed-by: Rich Salz MR: #2009 --- apps/spkac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'apps/spkac.c') diff --git a/apps/spkac.c b/apps/spkac.c index 9cbe7fe2e8..07f36d370d 100644 --- a/apps/spkac.c +++ b/apps/spkac.c @@ -112,6 +112,7 @@ int spkac_main(int argc, char **argv) switch (o) { case OPT_EOF: case OPT_ERR: + opthelp: BIO_printf(bio_err, "%s: Use -help for summary.\n", prog); goto end; case OPT_HELP: @@ -154,7 +155,8 @@ int spkac_main(int argc, char **argv) } } argc = opt_num_rest(); - argv = opt_rest(); + if (argc != 0) + goto opthelp; if (!app_passwd(passinarg, NULL, &passin, NULL)) { BIO_printf(bio_err, "Error getting password\n"); -- cgit v1.2.3