From dd1abd4462e4e4fa84b8f8de2ec70375f9b0e191 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Wed, 28 Sep 2016 23:39:18 +0200 Subject: If an engine comes up explicitely, it must also come down explicitely In apps/apps.c, one can set up an engine with setup_engine(). However, we freed the structural reference immediately, which means that for engines that don't already have a structural reference somewhere else (because it's a built in engine), we end up returning an invalid reference. Instead, the function release_engine() is added, and called at the end of the routines that call setup_engine(). Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/1643) --- apps/pkcs8.c | 1 + 1 file changed, 1 insertion(+) (limited to 'apps/pkcs8.c') diff --git a/apps/pkcs8.c b/apps/pkcs8.c index f31008a259..e12c5d36cd 100644 --- a/apps/pkcs8.c +++ b/apps/pkcs8.c @@ -343,6 +343,7 @@ int pkcs8_main(int argc, char **argv) X509_SIG_free(p8); PKCS8_PRIV_KEY_INFO_free(p8inf); EVP_PKEY_free(pkey); + release_engine(e); BIO_free_all(out); BIO_free(in); OPENSSL_free(passin); -- cgit v1.2.3