summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--CHANGES3
-rw-r--r--crypto/asn1/x_pubkey.c5
2 files changed, 7 insertions, 1 deletions
diff --git a/CHANGES b/CHANGES
index 4baace1e62..7cca7f00a7 100644
--- a/CHANGES
+++ b/CHANGES
@@ -291,6 +291,9 @@
Changes between 1.0.1c and 1.0.1d [xx XXX xxxx]
+ *) Fix possible deadlock when decoding public keys.
+ [Steve Henson]
+
*) Don't use TLS 1.0 record version number in initial client hello
if renegotiating.
[Steve Henson]
diff --git a/crypto/asn1/x_pubkey.c b/crypto/asn1/x_pubkey.c
index 627ec87f9f..b649e1fcf9 100644
--- a/crypto/asn1/x_pubkey.c
+++ b/crypto/asn1/x_pubkey.c
@@ -175,12 +175,15 @@ EVP_PKEY *X509_PUBKEY_get(X509_PUBKEY *key)
CRYPTO_w_lock(CRYPTO_LOCK_EVP_PKEY);
if (key->pkey)
{
+ CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY);
EVP_PKEY_free(ret);
ret = key->pkey;
}
else
+ {
key->pkey = ret;
- CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY);
+ CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY);
+ }
CRYPTO_add(&ret->references, 1, CRYPTO_LOCK_EVP_PKEY);
return ret;