diff options
| author | Richard Levitte <levitte@openssl.org> | 2022-09-14 07:07:41 +0200 |
|---|---|---|
| committer | Tomas Mraz <tomas@openssl.org> | 2022-09-15 08:43:11 +0200 |
| commit | d83c465754ab4bfeb33718ad5ac851388079daba (patch) | |
| tree | 06278208af19333d4f9479edeb5ac032e407bb15 /util | |
| parent | 684ba5c9422a9d111a6d971b7681814efd13a97b (diff) | |
util/wrap.pl.in: Use parentheses so `kill` gets all its arguments
In perl, this may be ambiguous:
fn (expr1), expr2
Is the comma (which may be `=>` just as well in this case) a separator
between arguments to `fn`, or is it the comma operator, separating the
expressions `fn(expr1)` and `expr2`? It appears that in this particular
case, perl takes the existing parentheses to mean the latter. When the
former was intended, extra parentheses are required.
Fixes #19209
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19211)
(cherry picked from commit ef6d6e452dc57ef4a55d7a6ec0693be650009bb5)
Diffstat (limited to 'util')
| -rw-r--r-- | util/wrap.pl.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/wrap.pl.in b/util/wrap.pl.in index de4692f319..5126513d4c 100644 --- a/util/wrap.pl.in +++ b/util/wrap.pl.in @@ -69,7 +69,7 @@ die "wrap.pl: Failed to execute '", join(' ', @cmd), "': $!\n" if $waitcode == -1; # When the subprocess aborted on a signal, we simply raise the same signal. -kill ($? & 255) => $$ if ($? & 255) != 0; +kill(($? & 255) => $$) if ($? & 255) != 0; # If that didn't stop this script, mimic what Unix shells do, by # converting the signal code to an exit code by setting the high bit. |