diff options
| author | Billy Brumley <bbrumley@gmail.com> | 2019-09-06 17:26:08 +0300 |
|---|---|---|
| committer | Nicola Tuveri <nic.tuv@gmail.com> | 2019-09-07 15:37:13 +0300 |
| commit | 5041ea38c96c9c8d7fc207a7fd25969f167f0f76 (patch) | |
| tree | 8ee55d371bda546435fccce8f81b0c8a88385e23 /test | |
| parent | e97bab6929bbbc5b8364b25ca2ef4fcb02dd6e2a (diff) | |
[test] computing ECC cofactors: regression test
This is a forward port from
https://github.com/openssl/openssl/pull/9781
for the test logic introduced by
https://github.com/openssl/openssl/pull/9727
As @mattcaswell commented
(https://github.com/openssl/openssl/pull/9781#discussion_r321621541):
> These `TEST_true` calls should be `!TEST_false` because we are
> *expecting* a failure.
> The difference is that the test framework will print error details if
> the test doesn't give the expected answer.
> So by using `TEST_true` instead of `!TEST_false` we'll get error
> details printed, but the test will succeed anyway.
(cherry picked from commit e8aafc891d9bd7fa1cce0401d858ef842f09b49e)
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9797)
Diffstat (limited to 'test')
| -rw-r--r-- | test/ectest.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/ectest.c b/test/ectest.c index 2cbbd4e340..b51a3b1207 100644 --- a/test/ectest.c +++ b/test/ectest.c @@ -1914,19 +1914,19 @@ static int cardinality_test(int n) /* negative test for invalid cofactor */ || !TEST_true(BN_set_word(g2_cf, 0)) || !TEST_true(BN_sub(g2_cf, g2_cf, BN_value_one())) - || TEST_true(EC_GROUP_set_generator(g2, g2_gen, g1_order, g2_cf)) + || !TEST_false(EC_GROUP_set_generator(g2, g2_gen, g1_order, g2_cf)) /* negative test for NULL order */ - || TEST_true(EC_GROUP_set_generator(g2, g2_gen, NULL, NULL)) + || !TEST_false(EC_GROUP_set_generator(g2, g2_gen, NULL, NULL)) /* negative test for zero order */ || !TEST_true(BN_set_word(g1_order, 0)) - || TEST_true(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL)) + || !TEST_false(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL)) /* negative test for negative order */ || !TEST_true(BN_set_word(g2_cf, 0)) || !TEST_true(BN_sub(g2_cf, g2_cf, BN_value_one())) - || TEST_true(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL)) + || !TEST_false(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL)) /* negative test for too large order */ || !TEST_true(BN_lshift(g1_order, g1_p, 2)) - || TEST_true(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL))) + || !TEST_false(EC_GROUP_set_generator(g2, g2_gen, g1_order, NULL))) goto err; ret = 1; err: |