Add some sig algs tests

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2157)

1 files changed, 200 insertions, 0 deletions

diff --git a/test/recipes/70-test_sslsigalgs.t b/test/recipes/70-test_sslsigalgs.t
new file mode 100755
index 0000000000..954b9c5038
--- /dev/null
+++ b/test/recipes/70-test_sslsigalgs.t
@@ -0,0 +1,200 @@
+#! /usr/bin/env perl
+# Copyright 2016 The OpenSSL Project Authors. All Rights Reserved.
+#
+# Licensed under the OpenSSL license (the "License").  You may not use
+# this file except in compliance with the License.  You can obtain a copy
+# in the file LICENSE in the source distribution or at
+# https://www.openssl.org/source/license.html
+
+use strict;
+use OpenSSL::Test qw/:DEFAULT cmdstr srctop_file bldtop_dir/;
+use OpenSSL::Test::Utils;
+use TLSProxy::Proxy;
+
+my $test_name = "test_sslsigalgs";
+setup($test_name);
+
+plan skip_all => "TLSProxy isn't usable on $^O"
+    if $^O =~ /^(VMS|MSWin32)$/;
+
+plan skip_all => "$test_name needs the dynamic engine feature enabled"
+    if disabled("engine") || disabled("dynamic-engine");
+
+plan skip_all => "$test_name needs the sock feature enabled"
+    if disabled("sock");
+
+plan skip_all => "$test_name needs TLS1.2 or TLS1.3 enabled"
+    if disabled("tls1_2") && disabled("tls1_3");
+
+$ENV{OPENSSL_ia32cap} = '~0x200000200000000';
+my $proxy = TLSProxy::Proxy->new(
+    undef,
+    cmdstr(app(["openssl"]), display => 1),
+    srctop_file("apps", "server.pem"),
+    (!$ENV{HARNESS_ACTIVE} || $ENV{HARNESS_VERBOSE})
+);
+
+use constant {
+    NO_SIG_ALGS_EXT => 0,
+    EMPTY_SIG_ALGS_EXT => 1,
+    NO_KNOWN_SIG_ALGS => 2,
+    NO_PSS_SIG_ALGS => 3,
+    PSS_ONLY_SIG_ALGS => 4
+};
+
+#Test 1: Default sig algs should succeed
+$proxy->start() or plan skip_all => "Unable to start up Proxy for tests";
+plan tests => 14;
+ok(TLSProxy::Message->success, "Default sigalgs");
+my $testtype;
+
+SKIP: {
+    skip "TLSv1.3 disabled", 5 if disabled("tls1_3");
+
+    $proxy->filter(\&sigalgs_filter);
+
+    #Test 2: Sending no sig algs extension in TLSv1.3 should fail
+    $proxy->clear();
+    $testtype = NO_SIG_ALGS_EXT;
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No TLSv1.3 sigalgs");
+
+    #Test 3: Sending an empty sig algs extension in TLSv1.3 should fail
+    $proxy->clear();
+    $testtype = EMPTY_SIG_ALGS_EXT;
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "Empty TLSv1.3 sigalgs");
+
+    #Test 4: Sending a list with no recognised sig algs in TLSv1.3 should fail
+    $proxy->clear();
+    $testtype = NO_KNOWN_SIG_ALGS;
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No known TLSv1.3 sigalgs");
+
+    #Test 5: Sending a sig algs list without pss for an RSA cert in TLSv1.3
+    #        should fail
+    $proxy->clear();
+    $testtype = NO_PSS_SIG_ALGS;
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No PSS TLSv1.3 sigalgs");
+
+    #Test 6: Sending only TLSv1.3 PSS sig algs in TLSv1.3 should succeed
+    #TODO(TLS1.3): Do we need to verify the cert to make sure its a PSS only
+    #cert in this case?
+    $proxy->clear();
+    $testtype = PSS_ONLY_SIG_ALGS;
+    $proxy->start();
+    ok(TLSProxy::Message->success, "PSS only sigalgs in TLSv1.3");
+}
+
+SKIP: {
+    skip "TLSv1.3 or TLSv1.2 disabled", 2
+        if disabled("tls1_2") || disabled("tls1_3");
+
+    #Test 7: Sending a valid sig algs list but not including a sig type that
+    #        matches the certificate should fail in TLSv1.3. We need TLSv1.2
+    #        enabled for this test - otherwise the client will not attempt to
+    #        connect due to no TLSv1.3 ciphers being available.
+    #        TODO(TLS1.3): When proper TLSv1.3 certificate selection is working
+    #        we can move this test into the section above
+    $proxy->clear();
+    $proxy->clientflags("-sigalgs ECDSA+SHA256");
+    $proxy->filter(undef);
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No matching TLSv1.3 sigalgs");
+
+    #Test 8: Sending a full list of TLSv1.3 sig algs but negotiating TLSv1.2
+    #        should succeed
+    $proxy->clear();
+    $proxy->serverflags("-no_tls1_3");
+    $proxy->filter(undef);
+    $proxy->start();
+    ok(TLSProxy::Message->success, "TLSv1.3 client TLSv1.2 server");
+}
+
+SKIP: {
+    skip "TLSv1.2 disabled", 6 if disabled("tls1_2");
+
+    $proxy->filter(\&sigalgs_filter);
+
+    #Test 9: Sending no sig algs extension in TLSv1.2 should succeed
+    $proxy->clear();
+    $testtype = NO_SIG_ALGS_EXT;
+    $proxy->clientflags("-no_tls1_3");
+    $proxy->start();
+    ok(TLSProxy::Message->success, "No TLSv1.2 sigalgs");
+
+    #Test 10: Sending an empty sig algs extension in TLSv1.2 should fail
+    $proxy->clear();
+    $testtype = EMPTY_SIG_ALGS_EXT;
+    $proxy->clientflags("-no_tls1_3");
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "Empty TLSv1.2 sigalgs");
+
+    #Test 11: Sending a list with no recognised sig algs in TLSv1.2 should fail
+    $proxy->clear();
+    $testtype = NO_KNOWN_SIG_ALGS;
+    $proxy->clientflags("-no_tls1_3");
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No known TLSv1.3 sigalgs");
+
+    #Test 12: Sending a sig algs list without pss for an RSA cert in TLSv1.2
+    #         should succeed
+    $proxy->clear();
+    $testtype = NO_PSS_SIG_ALGS;
+    $proxy->clientflags("-no_tls1_3");
+    $proxy->start();
+    ok(TLSProxy::Message->success, "No PSS TLSv1.2 sigalgs");
+
+    #Test 13: Sending only TLSv1.3 PSS sig algs in TLSv1.2 should fail
+    $proxy->clear();
+    $testtype = PSS_ONLY_SIG_ALGS;
+    $proxy->clientflags("-no_tls1_3");
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "PSS only sigalgs in TLSv1.2");
+
+    #Test 14: Sending a valid sig algs list but not including a sig type that
+    #         matches the certificate should fail in TLSv1.2
+    $proxy->clear();
+    $proxy->clientflags("-no_tls1_3 -sigalgs ECDSA+SHA256");
+    $proxy->filter(undef);
+    $proxy->start();
+    ok(TLSProxy::Message->fail, "No matching TLSv1.2 sigalgs");
+    $proxy->filter(\&sigalgs_filter);
+}
+
+
+
+sub sigalgs_filter
+{
+    my $proxy = shift;
+
+    # We're only interested in the initial ClientHello
+    if ($proxy->flight != 0) {
+        return;
+    }
+
+    foreach my $message (@{$proxy->message_list}) {
+        if ($message->mt == TLSProxy::Message::MT_CLIENT_HELLO) {
+            if ($testtype == NO_SIG_ALGS_EXT) {
+                $message->delete_extension(TLSProxy::Message::EXT_SIG_ALGS);
+            } else {
+                my $sigalg;
+                if ($testtype == EMPTY_SIG_ALGS_EXT) {
+                    $sigalg = pack "C2", 0x00, 0x00;
+                } elsif ($testtype == NO_KNOWN_SIG_ALGS) {
+                    $sigalg = pack "C4", 0x00, 0x02, 0xff, 0xff;
+                } elsif ($testtype == NO_PSS_SIG_ALGS) {
+                    #No PSS sig algs - just send rsa_pkcs1_sha256
+                    $sigalg = pack "C4", 0x00, 0x02, 0x04, 0x01;
+                } else {
+                    #PSS sig algs only - just send rsa_pss_sha256
+                    $sigalg = pack "C4", 0x00, 0x02, 0x08, 0x04;
+                }
+                $message->set_extension(TLSProxy::Message::EXT_SIG_ALGS, $sigalg);
+            }
+
+            $message->repack();
+        }
+    }
+}