diff options
author | David Benjamin <davidben@google.com> | 2021-12-29 13:05:12 -0500 |
---|---|---|
committer | Tomas Mraz <tomas@openssl.org> | 2022-11-09 15:30:43 +0100 |
commit | 0029f786658229b15f98741a336e8091305cbf15 (patch) | |
tree | 599881acc9ad10a24cc8d62fe9fe9dc7cb16fb3d /test/endecode_test.c | |
parent | 068c7fa995249894e5935003d1ac478de1df64f3 (diff) |
Don't use __ARMEL__/__ARMEB__ in aarch64 assembly
GCC's __ARMEL__ and __ARMEB__ defines denote little- and big-endian arm,
respectively. They are not defined on aarch64, which instead use
__AARCH64EL__ and __AARCH64EB__.
However, OpenSSL's assembly originally used the 32-bit defines on both
platforms and even define __ARMEL__ and __ARMEB__ in arm_arch.h. This is
less portable and can even interfere with other headers, which use
__ARMEL__ to detect little-endian arm.
Over time, the aarch64 assembly has switched to the correct defines,
such as in 32bbb62ea634239e7cb91d6450ba23517082bab6. This commit
finishes the job: poly1305-armv8.pl needed a fix and the dual-arch
armx.pl files get one more transform to convert from 32-bit to 64-bit.
(There is an even more official endianness detector, __ARM_BIG_ENDIAN in
the Arm C Language Extensions. But I've stuck with the GCC ones here as
that would be a larger change.)
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/17373)
(cherry picked from commit 40c24d74deaad8a0ad7566a68ea5ea757bc3ccef)
Diffstat (limited to 'test/endecode_test.c')
0 files changed, 0 insertions, 0 deletions