diff options
| author | Hugo Landau <hlandau@openssl.org> | 2022-11-30 07:57:55 +0000 |
|---|---|---|
| committer | Hugo Landau <hlandau@openssl.org> | 2023-01-13 13:20:19 +0000 |
| commit | 9bbc5b54b0f0c64d21eaea35ee3f9722aa77a56e (patch) | |
| tree | 9876e1e93ebf49b459663a5e5a45fcdb2d18151e /ssl | |
| parent | c8b3fdc2e4833b065c0f7f0ff6ab771c6ff6b1a9 (diff) | |
QUIC CHANNEL: Revise inaccurate comments
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19703)
Diffstat (limited to 'ssl')
| -rw-r--r-- | ssl/quic/quic_channel.c | 2 | ||||
| -rw-r--r-- | ssl/quic/quic_channel_local.h | 9 |
2 files changed, 7 insertions, 4 deletions
diff --git a/ssl/quic/quic_channel.c b/ssl/quic/quic_channel.c index b0752cda79..87406f4ee3 100644 --- a/ssl/quic/quic_channel.c +++ b/ssl/quic/quic_channel.c @@ -1529,7 +1529,7 @@ int ossl_quic_channel_on_handshake_confirmed(QUIC_CHANNEL *ch) * - If we are already TERMINATED this is a no-op. * * - If we are TERMINATING - CLOSING and we have now got a CONNECTION_CLOSE - * from the peer (tcause->remote == 1), we move to TERMINATING - CLOSING. + * from the peer (tcause->remote == 1), we move to TERMINATING - DRAINING. * * - If we are TERMINATING - DRAINING, we remain here until the terminating * timer expires. diff --git a/ssl/quic/quic_channel_local.h b/ssl/quic/quic_channel_local.h index 269781688f..a16422e6e1 100644 --- a/ssl/quic/quic_channel_local.h +++ b/ssl/quic/quic_channel_local.h @@ -246,9 +246,12 @@ struct quic_channel_st { unsigned int have_qsm : 1; /* - * Preferred EL for transmission. This is not strictly needed as it can be - * inferred from what keys we have provisioned, but makes determining the - * current EL simpler and faster. + * Preferred ELs for transmission and reception. This is not strictly needed + * as it can be inferred from what keys we have provisioned, but makes + * determining the current EL simpler and faster. A separate EL for + * transmission and reception is not strictly necessary but makes things + * easier for interoperation with the handshake layer, which likes to invoke + * the yield secret callback at different times for TX and RX. */ unsigned int tx_enc_level : 3; unsigned int rx_enc_level : 3; |