diff options
| author | Matt Caswell <matt@openssl.org> | 2018-02-09 18:03:08 +0000 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2018-02-12 10:06:39 +0000 |
| commit | 1d0c08b4963f5f7e1d1855e360417a11973d8455 (patch) | |
| tree | d7b74082b737242ebba6ebc167d7e1f1e2797621 /ssl/ssl_locl.h | |
| parent | 7e70213fe3c79461ad3d776a8de1a5beff4bea78 (diff) | |
The function ssl_get_min_max_version() can fail
We should always check the return code.
This fixes a coverity issue.
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5308)
Diffstat (limited to 'ssl/ssl_locl.h')
| -rw-r--r-- | ssl/ssl_locl.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ssl/ssl_locl.h b/ssl/ssl_locl.h index 221d5b903a..b590b53630 100644 --- a/ssl/ssl_locl.h +++ b/ssl/ssl_locl.h @@ -2310,7 +2310,8 @@ __owur int ssl_choose_server_version(SSL *s, CLIENTHELLO_MSG *hello, DOWNGRADE *dgrd); __owur int ssl_choose_client_version(SSL *s, int version, RAW_EXTENSION *extensions); -int ssl_get_min_max_version(const SSL *s, int *min_version, int *max_version); +__owur int ssl_get_min_max_version(const SSL *s, int *min_version, + int *max_version); __owur long tls1_default_timeout(void); __owur int dtls1_do_write(SSL *s, int type); @@ -2501,7 +2502,7 @@ __owur int tls1_set_peer_legacy_sigalg(SSL *s, const EVP_PKEY *pkey); __owur int tls1_lookup_md(const SIGALG_LOOKUP *lu, const EVP_MD **pmd); __owur size_t tls12_get_psigalgs(SSL *s, int sent, const uint16_t **psigs); __owur int tls12_check_peer_sigalg(SSL *s, uint16_t, EVP_PKEY *pkey); -void ssl_set_client_disabled(SSL *s); +__owur int ssl_set_client_disabled(SSL *s); __owur int ssl_cipher_disabled(SSL *s, const SSL_CIPHER *c, int op, int echde); __owur int ssl_handshake_hash(SSL *s, unsigned char *out, size_t outlen, |