diff options
author | Richard Levitte <levitte@openssl.org> | 2000-06-09 10:41:35 +0000 |
---|---|---|
committer | Richard Levitte <levitte@openssl.org> | 2000-06-09 10:41:35 +0000 |
commit | ef33b97050f8157234abe6d5f2da3da1cdda6d68 (patch) | |
tree | a2bb6602fdec189c9acae86bba54d7c1aaac4148 /ssl/ssl3.h | |
parent | 814ed26cfa66945a537f2764f543340845e561a5 (diff) |
Using checks of the existence of HEADER_{foo}_H in other header files
was a really bad idea. For example, the following:
#include <x509.h>
#include <bio.h>
#include <asn1.h>
would make sure that things like ASN1_UTCTIME_print() wasn't defined
unless you moved the inclusion of bio.h to above the inclusion of
x509.h. The reason is that x509.h includes asn1.h, and the
declaration of ASN1_UTCTIME_print() depended on the definition of
HEADER_BIO_H. That's what I call an obscure bug.
Instead, this change makes sure that whatever header files are needed
for the correct process of one header file are included automagically,
and that the definitions of, for example, BIO-related things are
dependent on the absence of the NO_{foo} macros. This is also
consistent with the way parts of OpenSSL can be excluded at will.
Diffstat (limited to 'ssl/ssl3.h')
-rw-r--r-- | ssl/ssl3.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ssl/ssl3.h b/ssl/ssl3.h index f616763830..7ee1feaa67 100644 --- a/ssl/ssl3.h +++ b/ssl/ssl3.h @@ -59,6 +59,9 @@ #ifndef HEADER_SSL3_H #define HEADER_SSL3_H +#ifndef NO_COMP +#include <openssl/comp.h> +#endif #include <openssl/buffer.h> #include <openssl/evp.h> #include <openssl/ssl.h> @@ -310,7 +313,7 @@ typedef struct ssl3_state_st const EVP_CIPHER *new_sym_enc; const EVP_MD *new_hash; -#ifdef HEADER_COMP_H +#ifndef NO_COMP const SSL_COMP *new_compression; #else char *new_compression; |