diff options
author | Matt Caswell <matt@openssl.org> | 2015-04-27 15:41:03 +0100 |
---|---|---|
committer | Matt Caswell <matt@openssl.org> | 2015-04-30 23:12:39 +0100 |
commit | 9d9e37744cd5119f9921315864d1cd28717173cd (patch) | |
tree | 6c14fa8f09884b04e99291db117eabe4a2e8958d /ssl/s3_cbc.c | |
parent | b86d7dca69f5c80abd60896c8ed3039fc56210cc (diff) |
Clarify logic in BIO_*printf functions
The static function dynamically allocates an output buffer if the output
grows larger than the static buffer that is normally used. The original
logic implied that |currlen| could be greater than |maxlen| which is
incorrect (and if so would cause a buffer overrun). Also the original
logic would call OPENSSL_malloc to create a dynamic buffer equal to the
size of the static buffer, and then immediately call OPENSSL_realloc to
make it bigger, rather than just creating a buffer than was big enough in
the first place. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot
Oberoi (Int3 Solutions) for reporting this issue.
Reviewed-by: Andy Polyakov <appro@openssl.org>
Diffstat (limited to 'ssl/s3_cbc.c')
0 files changed, 0 insertions, 0 deletions