diff options
| author | Matt Caswell <matt@openssl.org> | 2015-03-06 14:37:17 +0000 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2015-03-23 15:23:11 +0000 |
| commit | 69f682374868ba2b19a8aeada496bf03dbb037cf (patch) | |
| tree | 1c7717928dc7eecd832f2c864ff19c63af708ffc /ssl/d1_pkt.c | |
| parent | 4bcdb4a6019e57b3de077b17940e18befe745531 (diff) | |
Fix missing return value checks
Ensure that all functions have their return values checked where
appropriate. This covers all functions defined and called from within
libssl.
Reviewed-by: Richard Levitte <levitte@openssl.org>
Diffstat (limited to 'ssl/d1_pkt.c')
| -rw-r--r-- | ssl/d1_pkt.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/ssl/d1_pkt.c b/ssl/d1_pkt.c index 4dbd694442..5463acfe7f 100644 --- a/ssl/d1_pkt.c +++ b/ssl/d1_pkt.c @@ -937,7 +937,10 @@ int dtls1_read_bytes(SSL *s, int type, unsigned char *buf, int len, int peek) } #ifndef OPENSSL_NO_HEARTBEATS else if (rr->type == TLS1_RT_HEARTBEAT) { - dtls1_process_heartbeat(s); + /* We allow a 0 return */ + if(dtls1_process_heartbeat(s) < 0) { + return -1; + } /* Exit and notify application to read again */ rr->length = 0; @@ -1246,7 +1249,8 @@ int dtls1_read_bytes(SSL *s, int type, unsigned char *buf, int len, int peek) if (dtls1_check_timeout_num(s) < 0) return -1; - dtls1_retransmit_buffered_messages(s); + /* Ignore retransmit failures - swallow return code */ + if(dtls1_retransmit_buffered_messages(s)); rr->length = 0; goto start; } |