summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorBernd Edlinger <bernd.edlinger@hotmail.de>2021-11-22 21:50:04 +0100
committerBernd Edlinger <bernd.edlinger@hotmail.de>2022-02-09 17:07:58 +0100
commit38ac4415a9cc4cca307c866e5fc548b889fe2bb6 (patch)
tree455aedcd43070a6851e93c9fde73025f4659992d /include
parent8aa353679f0ad72f478a4800c22ad30f6b972370 (diff)
Prevent crash with engine using different openssl runtime
This problem happens usually because an application links libcrypto and/or libssl statically which installs an atexit handler, but later an engine using a shared instance of libcrypto is installed. The problem is in simple words that both instances of libcrypto have an atexit handler installed, but both are unable to coordinate with each other, which causes a crash, typically a use-after-free in the engine's destroy function. Work around that by preventing the engine's libcrypto to install the atexit handler. This may result in a small memory leak, but that memory is still reachable. Fixes #15898 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/17541)
Diffstat (limited to 'include')
-rw-r--r--include/openssl/engine.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/openssl/engine.h b/include/openssl/engine.h
index 0780f0fb5f..756751c6d3 100644
--- a/include/openssl/engine.h
+++ b/include/openssl/engine.h
@@ -722,6 +722,7 @@ typedef int (*dynamic_bind_engine) (ENGINE *e, const char *id,
CRYPTO_set_mem_functions(fns->mem_fns.malloc_fn, \
fns->mem_fns.realloc_fn, \
fns->mem_fns.free_fn); \
+ OPENSSL_init_crypto(OPENSSL_INIT_NO_ATEXIT, NULL); \
skip_cbs: \
if (!fn(e, id)) return 0; \
return 1; }