diff options
| author | Matt Caswell <matt@openssl.org> | 2015-05-19 16:03:02 +0100 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2015-05-22 23:43:07 +0100 |
| commit | c6eb1cbd1e2afbf0e0e9170cb9b5df1ff25bfd14 (patch) | |
| tree | 582be98a19c77a791fdf08f3e67413c44c35eeaf /doc/crypto/BN_rand.pod | |
| parent | 1a9499cf23dfd441628f37c29cfe5ac615255ee1 (diff) | |
Fix off-by-one in BN_rand
If BN_rand is called with |bits| set to 1 and |top| set to 1 then a 1 byte
buffer overflow can occur. There are no such instances within the OpenSSL at
the moment.
Thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke, Filip Palian for
discovering and reporting this issue.
Reviewed-by: Kurt Roeckx <kurt@openssl.org>
Diffstat (limited to 'doc/crypto/BN_rand.pod')
| -rw-r--r-- | doc/crypto/BN_rand.pod | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/crypto/BN_rand.pod b/doc/crypto/BN_rand.pod index d6b975ccf6..bd6bc86323 100644 --- a/doc/crypto/BN_rand.pod +++ b/doc/crypto/BN_rand.pod @@ -24,7 +24,8 @@ most significant bit of the random number can be zero. If B<top> is 0, it is set to 1, and if B<top> is 1, the two most significant bits of the number will be set to 1, so that the product of two such random numbers will always have 2*B<bits> length. If B<bottom> is true, the -number will be odd. +number will be odd. The value of B<bits> must be zero or greater. If B<bits> is +1 then B<top> cannot also be 1. BN_pseudo_rand() does the same, but pseudo-random numbers generated by this function are not necessarily unpredictable. They can be used for |