summaryrefslogtreecommitdiffstats
path: root/demos/smime
diff options
context:
space:
mode:
authorRich Salz <rsalz@openssl.org>2015-04-30 17:33:59 -0400
committerRich Salz <rsalz@openssl.org>2015-04-30 17:33:59 -0400
commit222561fe8ef510f336417a666f69f81ddc9b8fe4 (patch)
tree70bc6af70550022bc7b7af45bd3c6d64d7fc2680 /demos/smime
parent2ace745022f5af0709297e96eb0b0829c87c4291 (diff)
free NULL cleanup 5a
Don't check for NULL before calling a free routine. This gets X509_.*free: x509_name_ex_free X509_policy_tree_free X509_VERIFY_PARAM_free X509_STORE_free X509_STORE_CTX_free X509_PKEY_free X509_OBJECT_free_contents X509_LOOKUP_free X509_INFO_free Reviewed-by: Richard Levitte <levitte@openssl.org>
Diffstat (limited to 'demos/smime')
-rw-r--r--demos/smime/smdec.c3
-rw-r--r--demos/smime/smenc.c6
-rw-r--r--demos/smime/smsign.c3
-rw-r--r--demos/smime/smsign2.c6
-rw-r--r--demos/smime/smver.c3
5 files changed, 7 insertions, 14 deletions
diff --git a/demos/smime/smdec.c b/demos/smime/smdec.c
index 9752dea1f9..f1a987a34e 100644
--- a/demos/smime/smdec.c
+++ b/demos/smime/smdec.c
@@ -58,8 +58,7 @@ int main(int argc, char **argv)
ERR_print_errors_fp(stderr);
}
PKCS7_free(p7);
- if (rcert)
- X509_free(rcert);
+ X509_free(rcert);
EVP_PKEY_free(rkey);
BIO_free(in);
BIO_free(out);
diff --git a/demos/smime/smenc.c b/demos/smime/smenc.c
index 2e594ee89e..79fe2d0e10 100644
--- a/demos/smime/smenc.c
+++ b/demos/smime/smenc.c
@@ -72,10 +72,8 @@ int main(int argc, char **argv)
ERR_print_errors_fp(stderr);
}
PKCS7_free(p7);
- if (rcert)
- X509_free(rcert);
- if (recips)
- sk_X509_pop_free(recips, X509_free);
+ X509_free(rcert);
+ sk_X509_pop_free(recips, X509_free);
BIO_free(in);
BIO_free(out);
BIO_free(tbio);
diff --git a/demos/smime/smsign.c b/demos/smime/smsign.c
index 91ab8e475d..8505e7140b 100644
--- a/demos/smime/smsign.c
+++ b/demos/smime/smsign.c
@@ -68,8 +68,7 @@ int main(int argc, char **argv)
ERR_print_errors_fp(stderr);
}
PKCS7_free(p7);
- if (scert)
- X509_free(scert);
+ X509_free(scert);
EVP_PKEY_free(skey);
BIO_free(in);
BIO_free(out);
diff --git a/demos/smime/smsign2.c b/demos/smime/smsign2.c
index 0ad709d041..415ecf395f 100644
--- a/demos/smime/smsign2.c
+++ b/demos/smime/smsign2.c
@@ -76,11 +76,9 @@ int main(int argc, char **argv)
ERR_print_errors_fp(stderr);
}
PKCS7_free(p7);
- if (scert)
- X509_free(scert);
+ X509_free(scert);
EVP_PKEY_free(skey);
- if (scert2)
- X509_free(scert2);
+ X509_free(scert2);
EVP_PKEY_free(skey2);
BIO_free(in);
BIO_free(out);
diff --git a/demos/smime/smver.c b/demos/smime/smver.c
index c4b6e751a9..13ba18b9b9 100644
--- a/demos/smime/smver.c
+++ b/demos/smime/smver.c
@@ -66,8 +66,7 @@ int main(int argc, char **argv)
ERR_print_errors_fp(stderr);
}
PKCS7_free(p7);
- if (cacert)
- X509_free(cacert);
+ X509_free(cacert);
BIO_free(in);
BIO_free(out);
BIO_free(tbio);