summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorBilly Brumley <bbrumley@gmail.com>2018-04-11 10:10:58 +0300
committerMatt Caswell <matt@openssl.org>2018-04-16 16:21:05 +0100
commit349a41da1ad88ad87825414752a8ff5fdd6a6c3f (patch)
treef7de2191483048af0e3dd410bc74eb8ba41c143e /crypto
parentd1a64149b061172d120559aea289498ec680b497 (diff)
RSA key generation: ensure BN_mod_inverse and BN_mod_exp_mont both get called with BN_FLG_CONSTTIME flag set.
CVE-2018-0737 Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 6939eab03a6e23d2bd2c3f5e34fe1d48e542e787)
Diffstat (limited to 'crypto')
-rw-r--r--crypto/rsa/rsa_gen.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto/rsa/rsa_gen.c b/crypto/rsa/rsa_gen.c
index 9ca5dfefb7..42b89a8dfa 100644
--- a/crypto/rsa/rsa_gen.c
+++ b/crypto/rsa/rsa_gen.c
@@ -156,6 +156,8 @@ static int rsa_builtin_keygen(RSA *rsa, int bits, BIGNUM *e_value,
if (BN_copy(rsa->e, e_value) == NULL)
goto err;
+ BN_set_flags(rsa->p, BN_FLG_CONSTTIME);
+ BN_set_flags(rsa->q, BN_FLG_CONSTTIME);
BN_set_flags(r2, BN_FLG_CONSTTIME);
/* generate p and q */
for (;;) {