diff options
| author | Viktor Dukhovni <openssl-users@dukhovni.org> | 2016-01-13 19:51:17 -0500 |
|---|---|---|
| committer | Viktor Dukhovni <openssl-users@dukhovni.org> | 2016-01-13 19:58:57 -0500 |
| commit | b098dcae66433efc4c073ca2cc5fc64cdf8a613e (patch) | |
| tree | c3471541000c35a069df33c513f0041b8609718b /crypto | |
| parent | 502e16853367f373ec2aad94f1fd24884c4a7b65 (diff) | |
Fix double-free bugs in EC group precomputation state
Reviewed-by: Rich Salz <rsalz@openssl.org>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/ec/ecp_nistp224.c | 1 | ||||
| -rw-r--r-- | crypto/ec/ecp_nistp256.c | 1 | ||||
| -rw-r--r-- | crypto/ec/ecp_nistp521.c | 1 | ||||
| -rw-r--r-- | crypto/ec/ecp_nistz256.c | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/crypto/ec/ecp_nistp224.c b/crypto/ec/ecp_nistp224.c index c2677a85d5..a2def18031 100644 --- a/crypto/ec/ecp_nistp224.c +++ b/crypto/ec/ecp_nistp224.c @@ -1560,6 +1560,7 @@ int ec_GFp_nistp224_precompute_mult(EC_GROUP *group, BN_CTX *ctx) /* throw away old precomputation */ EC_nistp224_pre_comp_free(group->pre_comp.nistp224); + group->pre_comp.nistp224 = NULL; if (ctx == NULL) if ((ctx = new_ctx = BN_CTX_new()) == NULL) return 0; diff --git a/crypto/ec/ecp_nistp256.c b/crypto/ec/ecp_nistp256.c index 26c1693778..11bde8a50f 100644 --- a/crypto/ec/ecp_nistp256.c +++ b/crypto/ec/ecp_nistp256.c @@ -2185,6 +2185,7 @@ int ec_GFp_nistp256_precompute_mult(EC_GROUP *group, BN_CTX *ctx) /* throw away old precomputation */ EC_nistp256_pre_comp_free(group->pre_comp.nistp256); + group->pre_comp.nistp256 = NULL; if (ctx == NULL) if ((ctx = new_ctx = BN_CTX_new()) == NULL) return 0; diff --git a/crypto/ec/ecp_nistp521.c b/crypto/ec/ecp_nistp521.c index 516101c186..d656517791 100644 --- a/crypto/ec/ecp_nistp521.c +++ b/crypto/ec/ecp_nistp521.c @@ -2009,6 +2009,7 @@ int ec_GFp_nistp521_precompute_mult(EC_GROUP *group, BN_CTX *ctx) /* throw away old precomputation */ EC_nistp521_pre_comp_free(group->pre_comp.nistp521); + group->pre_comp.nistp521 = NULL; if (ctx == NULL) if ((ctx = new_ctx = BN_CTX_new()) == NULL) return 0; diff --git a/crypto/ec/ecp_nistz256.c b/crypto/ec/ecp_nistz256.c index 16e79299c9..c25a7daf3c 100644 --- a/crypto/ec/ecp_nistz256.c +++ b/crypto/ec/ecp_nistz256.c @@ -770,6 +770,7 @@ __owur static int ecp_nistz256_mult_precompute(EC_GROUP *group, BN_CTX *ctx) /* if there is an old NISTZ256_PRE_COMP object, throw it away */ EC_nistz256_pre_comp_free(group->pre_comp.nistz256); + group->pre_comp.nistz256 = NULL; generator = EC_GROUP_get0_generator(group); if (generator == NULL) { ECerr(EC_F_ECP_NISTZ256_MULT_PRECOMPUTE, EC_R_UNDEFINED_GENERATOR); |